From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbdKHRfz (ORCPT ); Wed, 8 Nov 2017 12:35:55 -0500 Received: from smtprelay0210.hostedemail.com ([216.40.44.210]:37297 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751716AbdKHRfy (ORCPT ); Wed, 8 Nov 2017 12:35:54 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 64,4,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2332:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3874:4321:4605:5007:7875:7903:7974:9010:10004:10400:10848:11232:11658:11914:12043:12555:12663:12740:12760:12895:13069:13255:13311:13357:13439:13618:14180:14181:14659:14721:21060:21080:21325:21451:21627:30054:30060:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: box18_50645dd17b129 X-Filterd-Recvd-Size: 2635 Message-ID: <1510162550.15768.27.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver From: Joe Perches To: Masahiro Yamada , Andrew Morton Cc: Paul Gortmaker , Linux Kernel Mailing List , Andy Whitcroft Date: Wed, 08 Nov 2017 09:35:50 -0800 In-Reply-To: References: <1505700081-12854-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-08 at 22:32 +0900, Masahiro Yamada wrote: > Hi Joe, Andrew, > > (sorry, Andrew was missing from the list...) > > 2017-09-18 11:01 GMT+09:00 Masahiro Yamada : > > checkpatch.pl does not check missing blank line before module_*_driver. > > I want it to behave likewise for builtin_*_driver. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > Changes in v2: > > - Improve the matching pattern as suggested by Joe Perches > > > > scripts/checkpatch.pl | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index dd2c262aebbf..5c6179c63cf6 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -3103,6 +3103,7 @@ sub process { > > $line =~ /^\+[a-z_]*init/ || > > $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || > > $line =~ /^\+\s*DECLARE/ || > > + $line =~ /^\+\s*builtin_[\w_]*driver/ || > > $line =~ /^\+\s*__setup/)) { > > if (CHK("LINE_SPACING", > > "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) && > > -- > > 2.7.4 > > > > > Is this patch good for 4.15-rc1? > > "git log scripts/checkpatch.pl" shows > this kind of patch is generally picked up by Andrew. > > > If Joe issues Acked-by, that will be very helpful > for applying this patch. Acked-by: Joe Perches