* [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver
@ 2017-09-18 2:01 Masahiro Yamada
2017-11-08 13:32 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2017-09-18 2:01 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches; +Cc: Paul Gortmaker, Masahiro Yamada, linux-kernel
checkpatch.pl does not check missing blank line before module_*_driver.
I want it to behave likewise for builtin_*_driver.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2:
- Improve the matching pattern as suggested by Joe Perches
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dd2c262aebbf..5c6179c63cf6 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3103,6 +3103,7 @@ sub process {
$line =~ /^\+[a-z_]*init/ ||
$line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
$line =~ /^\+\s*DECLARE/ ||
+ $line =~ /^\+\s*builtin_[\w_]*driver/ ||
$line =~ /^\+\s*__setup/)) {
if (CHK("LINE_SPACING",
"Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver
2017-09-18 2:01 [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver Masahiro Yamada
@ 2017-11-08 13:32 ` Masahiro Yamada
2017-11-08 17:35 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2017-11-08 13:32 UTC (permalink / raw)
To: Joe Perches, Andrew Morton
Cc: Paul Gortmaker, Masahiro Yamada, Linux Kernel Mailing List,
Andy Whitcroft
Hi Joe, Andrew,
(sorry, Andrew was missing from the list...)
2017-09-18 11:01 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> checkpatch.pl does not check missing blank line before module_*_driver.
> I want it to behave likewise for builtin_*_driver.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Improve the matching pattern as suggested by Joe Perches
>
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dd2c262aebbf..5c6179c63cf6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3103,6 +3103,7 @@ sub process {
> $line =~ /^\+[a-z_]*init/ ||
> $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
> $line =~ /^\+\s*DECLARE/ ||
> + $line =~ /^\+\s*builtin_[\w_]*driver/ ||
> $line =~ /^\+\s*__setup/)) {
> if (CHK("LINE_SPACING",
> "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
> --
> 2.7.4
>
Is this patch good for 4.15-rc1?
"git log scripts/checkpatch.pl" shows
this kind of patch is generally picked up by Andrew.
If Joe issues Acked-by, that will be very helpful
for applying this patch.
Thanks!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver
2017-11-08 13:32 ` Masahiro Yamada
@ 2017-11-08 17:35 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2017-11-08 17:35 UTC (permalink / raw)
To: Masahiro Yamada, Andrew Morton
Cc: Paul Gortmaker, Linux Kernel Mailing List, Andy Whitcroft
On Wed, 2017-11-08 at 22:32 +0900, Masahiro Yamada wrote:
> Hi Joe, Andrew,
>
> (sorry, Andrew was missing from the list...)
>
> 2017-09-18 11:01 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > checkpatch.pl does not check missing blank line before module_*_driver.
> > I want it to behave likewise for builtin_*_driver.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > Changes in v2:
> > - Improve the matching pattern as suggested by Joe Perches
> >
> > scripts/checkpatch.pl | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index dd2c262aebbf..5c6179c63cf6 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3103,6 +3103,7 @@ sub process {
> > $line =~ /^\+[a-z_]*init/ ||
> > $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
> > $line =~ /^\+\s*DECLARE/ ||
> > + $line =~ /^\+\s*builtin_[\w_]*driver/ ||
> > $line =~ /^\+\s*__setup/)) {
> > if (CHK("LINE_SPACING",
> > "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
> > --
> > 2.7.4
> >
>
>
> Is this patch good for 4.15-rc1?
>
> "git log scripts/checkpatch.pl" shows
> this kind of patch is generally picked up by Andrew.
>
>
> If Joe issues Acked-by, that will be very helpful
> for applying this patch.
Acked-by: Joe Perches <joe@perches.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-08 17:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-18 2:01 [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver Masahiro Yamada
2017-11-08 13:32 ` Masahiro Yamada
2017-11-08 17:35 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox