* [PATCH] media: coda: remove definition of CODA_STD_MJPG
@ 2017-11-08 18:58 Martin Kepplinger
2017-11-09 9:11 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2017-11-08 18:58 UTC (permalink / raw)
To: p.zabel, mchehab; +Cc: linux-media, linux-kernel, Martin Kepplinger
According to i.MX VPU API Reference Manuals the MJPG video codec is
refernced to by number 7, not 3.
Also Philipp pointed out that this value is only meant to fill in
CMD_ENC_SEQ_COD_STD for encoding, only on i.MX53. It was never written
to any register, and even if defined correctly, wouldn't be needed
for i.MX6.
So avoid confusion and remove this definition.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/media/platform/coda/coda_regs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda_regs.h b/drivers/media/platform/coda/coda_regs.h
index 38df5fd9a2fa..35e620c7f1f4 100644
--- a/drivers/media/platform/coda/coda_regs.h
+++ b/drivers/media/platform/coda/coda_regs.h
@@ -254,7 +254,6 @@
#define CODA9_STD_H264 0
#define CODA_STD_H263 1
#define CODA_STD_H264 2
-#define CODA_STD_MJPG 3
#define CODA9_STD_MPEG4 3
#define CODA_CMD_ENC_SEQ_SRC_SIZE 0x190
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: coda: remove definition of CODA_STD_MJPG
2017-11-08 18:58 [PATCH] media: coda: remove definition of CODA_STD_MJPG Martin Kepplinger
@ 2017-11-09 9:11 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2017-11-09 9:11 UTC (permalink / raw)
To: Martin Kepplinger, mchehab; +Cc: linux-media, linux-kernel
On Wed, 2017-11-08 at 19:58 +0100, Martin Kepplinger wrote:
> According to i.MX VPU API Reference Manuals the MJPG video codec is
> refernced to by number 7, not 3.
>
> Also Philipp pointed out that this value is only meant to fill in
> CMD_ENC_SEQ_COD_STD for encoding, only on i.MX53. It was never written
> to any register, and even if defined correctly, wouldn't be needed
> for i.MX6.
>
> So avoid confusion and remove this definition.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/media/platform/coda/coda_regs.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/coda/coda_regs.h b/drivers/media/platform/coda/coda_regs.h
> index 38df5fd9a2fa..35e620c7f1f4 100644
> --- a/drivers/media/platform/coda/coda_regs.h
> +++ b/drivers/media/platform/coda/coda_regs.h
> @@ -254,7 +254,6 @@
> #define CODA9_STD_H264 0
> #define CODA_STD_H263 1
> #define CODA_STD_H264 2
> -#define CODA_STD_MJPG 3
> #define CODA9_STD_MPEG4 3
>
> #define CODA_CMD_ENC_SEQ_SRC_SIZE 0x190
Thanks,
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-09 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-08 18:58 [PATCH] media: coda: remove definition of CODA_STD_MJPG Martin Kepplinger
2017-11-09 9:11 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).