From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753995AbdKIJLa (ORCPT ); Thu, 9 Nov 2017 04:11:30 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37381 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbdKIJLU (ORCPT ); Thu, 9 Nov 2017 04:11:20 -0500 Message-ID: <1510218675.7659.0.camel@pengutronix.de> Subject: Re: [PATCH] media: coda: remove definition of CODA_STD_MJPG From: Philipp Zabel To: Martin Kepplinger , mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 09 Nov 2017 10:11:15 +0100 In-Reply-To: <20171108185803.12408-1-martink@posteo.de> References: <20171108185803.12408-1-martink@posteo.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-08 at 19:58 +0100, Martin Kepplinger wrote: > According to i.MX VPU API Reference Manuals the MJPG video codec is > refernced to by number 7, not 3. > > Also Philipp pointed out that this value is only meant to fill in > CMD_ENC_SEQ_COD_STD for encoding, only on i.MX53. It was never written > to any register, and even if defined correctly, wouldn't be needed > for i.MX6. > > So avoid confusion and remove this definition. > > Signed-off-by: Martin Kepplinger > --- > drivers/media/platform/coda/coda_regs.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/coda/coda_regs.h b/drivers/media/platform/coda/coda_regs.h > index 38df5fd9a2fa..35e620c7f1f4 100644 > --- a/drivers/media/platform/coda/coda_regs.h > +++ b/drivers/media/platform/coda/coda_regs.h > @@ -254,7 +254,6 @@ > #define CODA9_STD_H264 0 > #define CODA_STD_H263 1 > #define CODA_STD_H264 2 > -#define CODA_STD_MJPG 3 > #define CODA9_STD_MPEG4 3 > > #define CODA_CMD_ENC_SEQ_SRC_SIZE 0x190 Thanks, Acked-by: Philipp Zabel regards Philipp