From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbdKIPj2 (ORCPT ); Thu, 9 Nov 2017 10:39:28 -0500 Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:46567 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752705AbdKIPj1 (ORCPT ); Thu, 9 Nov 2017 10:39:27 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3653:3742:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:6117:6119:6691:7901:10004:10400:10848:11232:11658:11914:12555:12740:12760:12895:13069:13160:13161:13184:13229:13311:13357:13439:14181:14659:14721:21080:21627:30054:30060:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pin29_8c7809a495506 X-Filterd-Recvd-Size: 2649 Message-ID: <1510241963.15768.57.camel@perches.com> Subject: Re: [PATCH] checkpatch.pl: Add SPDX license tag check From: Joe Perches To: Rob Herring Cc: Linux Kernel Mailing List , Andy Whitcroft , Greg Kroah-Hartman Date: Thu, 09 Nov 2017 07:39:23 -0800 In-Reply-To: References: <20171109011047.20040-1-robh@kernel.org> <1510193419.15768.37.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-09 at 07:47 -0600, Rob Herring wrote: > On Wed, Nov 8, 2017 at 8:10 PM, Joe Perches wrote: > > On Wed, 2017-11-08 at 19:10 -0600, Rob Herring wrote: > > > Add a check warning if SPDX-License-Identifier tags are not used in > > > newly added files. > > > > If this is to be done, and I think it's not a great idea, > > Which part? SPDX tags or checking new files or just using checkpatch for this? SPDX tags in all files. There's no real way to check a patch for this. You have to check the entire file. checkpatch could, as you've done, scan for new files against /dev/null, but a single patch can add multiple files and each newly added file should have a missing SPDX indicator check. My concern is that there are ~50,000 files in the kernel source tree and, after that scripted patch adding the tags, only about a quarter of them have an SPDX tag. So which files actually _need_ a SPDX tag? files in -next with an SPDX tag: $ git grep --name-only -i -P "spdx-licen[cs]e-identifier" | \ while read file ; do basename $file ; done | \ sed -r -e 's/^.*(\..*)/\1/' | \ sort | uniq -c | sort -rn | head -10 7514 .h 3435 .c 1193 Makefile 486 .S 221 .dts 186 Kconfig 185 .dtsi 97 .sh 34 .tc 24 .debug vs all files in -next (not Documentation/) $ git ls-files | grep -v "^Documentation/" | \ while read file ; do basename $file ; done | \ sed -r -e 's/^.*(\..*)/\1/' | \ sort | uniq -c | sort -rn | head -10 25946 .c 20360 .h 2437 Makefile 1454 .S 1442 .dts 1380 Kconfig 1099 .dtsi 207 .json 204 .gitignore 194 .sh