From: Stefan Schake <stschake@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-rpi-kernel@lists.infradead.org,
Stefan Schake <stschake@gmail.com>, Eric Anholt <eric@anholt.net>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] drm/vc4: Correctly uninstall interrupts
Date: Fri, 10 Nov 2017 02:05:05 +0100 [thread overview]
Message-ID: <1510275907-993-1-git-send-email-stschake@gmail.com> (raw)
This set of patches fixes issues with vc4_irq_uninstall.
The first patch fixes a NULL pointer dereference when the binner BO
would disappear during an in flight overflow mem work callback.
The second patch ensures we return with all interrupts disabled. This was
suspected to cause the NULL dereference but turned out to be unrelated.
Tested with a Raspberry Pi CM 3 that was previously stuck in a boot loop
due to the issue. With the patch applied, the NULL dereference was no
longer observed through numerous resets.
Stefan Schake (2):
drm/vc4: Account for interrupts in flight
drm/vc4: Ensure interrupts are disabled
drivers/gpu/drm/vc4/vc4_irq.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
--
1.9.1
next reply other threads:[~2017-11-10 1:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 1:05 Stefan Schake [this message]
2017-11-10 1:05 ` [PATCH 1/2] drm/vc4: Account for interrupts in flight Stefan Schake
2017-11-14 0:59 ` Eric Anholt
2017-11-10 1:05 ` [PATCH 2/2] drm/vc4: Ensure interrupts are disabled Stefan Schake
2017-11-14 0:18 ` Eric Anholt
2017-11-14 11:43 ` Stefan Schake
2017-11-14 19:44 ` Eric Anholt
2017-11-14 23:18 ` Stefan Schake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510275907-993-1-git-send-email-stschake@gmail.com \
--to=stschake@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).