From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753965AbdKJUNn (ORCPT ); Fri, 10 Nov 2017 15:13:43 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37750 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753328AbdKJUNl (ORCPT ); Fri, 10 Nov 2017 15:13:41 -0500 Subject: Re: [RFC PATCH] fw_lockdown: new micro LSM module to prevent loading unsigned firmware From: Mimi Zohar To: David Howells Cc: linux-security-module , linux-fsdevel , linux-kernel , "Luis R. Rodriguez" , "AKASHI, Takahiro" Date: Fri, 10 Nov 2017 15:13:32 -0500 In-Reply-To: <1510336703.3404.17.camel@linux.vnet.ibm.com> References: <1510336703.3404.17.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17111020-0020-0000-0000-000003CAF493 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111020-0021-0000-0000-00004260182F Message-Id: <1510344812.3404.28.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-10_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711100276 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-11-10 at 12:58 -0500, Mimi Zohar wrote: > > + > +static struct security_hook_list fw_lockdown_hooks[] = { > + LSM_HOOK_INIT(fw_lockdown_file_check, fw_lockdown_bprm_check) Sigh, that should have be: LSM_HOOK_INIT(kernel_read_file, fw_lockdown_read_file) > +};