From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754036AbdKJUk7 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Nov 2017 15:40:59 -0500
Received: from imap1.codethink.co.uk ([176.9.8.82]:56828 "EHLO
        imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753686AbdKJUk5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Nov 2017 15:40:57 -0500
Message-ID: <1510346453.2465.60.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 34/46] crypto: xts - Add ECB dependency
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Milan Broz <gmazyland@gmail.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Sasha Levin <alexander.levin@verizon.com>
Date: Fri, 10 Nov 2017 20:40:53 +0000
In-Reply-To: <20171019134847.472741842@linuxfoundation.org>
References: <20171019134845.293630834@linuxfoundation.org>
         <20171019134847.472741842@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-10-19 at 15:49 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: Milan Broz <gmazyland@gmail.com>
> 
> 
> [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ]
> 
> Since the
>    commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40
>    crypto: xts - Convert to skcipher

That commit went into 4.10, and not any stable branches.  So this fix
doesn't appear to be appropriate for the older branches it was applied
to.

Ben.

> the XTS mode is based on ECB, so the mode must select
> ECB otherwise it can fail to initialize.
> 
> Signed-off-by: Milan Broz <gmazyland@gmail.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  crypto/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -343,6 +343,7 @@ config CRYPTO_XTS
>  	select CRYPTO_BLKCIPHER
>  	select CRYPTO_MANAGER
>  	select CRYPTO_GF128MUL
> +	select CRYPTO_ECB
>  	help
>  	  XTS: IEEE1619/D16 narrow block cipher use with aes-xts-
> plain,
>  	  key size 256, 384 or 512 bits. This implementation
> currently
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.