From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755148AbdKNNyz (ORCPT ); Tue, 14 Nov 2017 08:54:55 -0500 Received: from a2nlsmtp01-03.prod.iad2.secureserver.net ([198.71.225.37]:60914 "EHLO a2nlsmtp01-03.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754910AbdKNNyk (ORCPT ); Tue, 14 Nov 2017 08:54:40 -0500 x-originating-ip: 107.180.71.197 From: kys@exchange.microsoft.com To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, marcelo.cerri@canonical.com, sthemmin@microsoft.com Cc: Dexuan Cui , stable@vger.kernel.org, "K. Y. Srinivasan" Subject: [PATCH 1/2] vmbus: unregister device_obj->channels_kset Date: Tue, 14 Nov 2017 06:53:32 -0700 Message-Id: <1510667613-3035-1-git-send-email-kys@exchange.microsoft.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1510667553-2991-1-git-send-email-kys@exchange.microsoft.com> References: <1510667553-2991-1-git-send-email-kys@exchange.microsoft.com> Reply-To: kys@microsoft.com X-CMAE-Envelope: MS4wfPkiVvjNMESmGfJEZwU5sVirYh/VXGsCZea716TCgFV+GzzdEJPsiAH1AiTFXqphwS91Oa179HObX0UKYadKQLESzkFotYefEi28/RKfXIDvrmX95N4t hYN+uyiT40dDZd6lfxXsjiCiwNss9LEemeBKklUZUcK3KJFVFo+6/4Wvp6R+Tq/9bhRa7r958m/5va2xP1SYDC8hb9xXXSSBQyYg34JsENMw4R+SpF1RjM+4 jQIznSRytx8eW8u1ZoWtSuDCaf/4nrNxJ+DQ+KyUnfWxfSbFLoJSKjBPjtcsGBoS020G2Azit5MFGjXr6SifQ2ha/BszmWSSz5AB5bT7XZtpDJxx3EZAUWF6 35LoFT6ibyXXd4WTxk5keCYWmXLYVxMWQoXkPIY5UDP/04OrOVgQgNjt0tXFh+TK7vI2fkEQpUY/bUUE69abyuUr/G2+AZK5IdYiuuSL+x7TtKzZULFLAB4y yMJ1T7Lne+0S3htVS5tAphaGattf6yp24wdrhlp4+/5fMM7ObPSMA4GnMTDADuREpJgjyS/sQDPR8AZQGP2HHXW+P+ua1FnGcikMAspzalxnh4msV6xgzlHs 0cTIBwVARt7TnRiTqAsUGnCR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dexuan Cui Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj. Signed-off-by: Dexuan Cui Cc: Stephen Hemminger Cc: stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 6a86746..4f3faf5 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -1378,6 +1378,8 @@ void vmbus_device_unregister(struct hv_device *device_obj) pr_debug("child device %s unregistered\n", dev_name(&device_obj->device)); + kset_unregister(device_obj->channels_kset); + /* * Kick off the process of unregistering the device. * This will call vmbus_remove() and eventually vmbus_device_release() -- 1.7.1