* [PATCH] pinctrl: sh-pfc: remove unnecessary platform_set_drvdata()
@ 2013-08-22 2:00 Jingoo Han
2013-08-22 11:04 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-22 2:00 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: linux-kernel, laurent.pinchart+renesas, 'Simon Horman',
'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pinctrl/sh-pfc/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
index 9e66614..738f14f 100644
--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -539,8 +539,6 @@ static int sh_pfc_remove(struct platform_device *pdev)
if (pfc->info->ops && pfc->info->ops->exit)
pfc->info->ops->exit(pfc);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: remove unnecessary platform_set_drvdata()
2013-08-22 2:00 [PATCH] pinctrl: sh-pfc: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-22 11:04 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2013-08-22 11:04 UTC (permalink / raw)
To: Jingoo Han, 'Simon Horman'; +Cc: 'Linus Walleij', linux-kernel
Hi Jingoo,
Thank you for the patch.
On Thursday 22 August 2013 11:00:55 Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Linus, can you take this for v3.12 ? If it's too late I'll take it in my tree
and will include it in the v3.13 pull request.
> ---
> drivers/pinctrl/sh-pfc/core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 9e66614..738f14f 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -539,8 +539,6 @@ static int sh_pfc_remove(struct platform_device *pdev)
> if (pfc->info->ops && pfc->info->ops->exit)
> pfc->info->ops->exit(pfc);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-22 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 2:00 [PATCH] pinctrl: sh-pfc: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 11:04 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox