From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751360AbdKUOtr convert rfc822-to-8bit (ORCPT ); Tue, 21 Nov 2017 09:49:47 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:42459 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdKUOtp (ORCPT ); Tue, 21 Nov 2017 09:49:45 -0500 Message-ID: <1511275666.14446.1.camel@oracle.com> Subject: Re: [PATCH v1] mm: relax deferred struct page requirements From: Khalid Aziz To: Pavel Tatashin , steven.sistare@oracle.com, daniel.m.jordan@oracle.com, benh@kernel.crashing.org, paulus@samba.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, arbab@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, mhocko@suse.com, linux-mm@kvack.org, linux-s390@vger.kernel.org, mgorman@techsingularity.net Date: Tue, 21 Nov 2017 07:47:46 -0700 In-Reply-To: <20171117014601.31606-1-pasha.tatashin@oracle.com> References: <20171117014601.31606-1-pasha.tatashin@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-16 at 20:46 -0500, Pavel Tatashin wrote: > There is no need to have ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT, > as all the page initialization code is in common code. > > Also, there is no need to depend on MEMORY_HOTPLUG, as initialization > code > does not really use hotplug memory functionality. So, we can remove > this > requirement as well. > > This patch allows to use deferred struct page initialization on all > platforms with memblock allocator. > > Tested on x86, arm64, and sparc. Also, verified that code compiles on > PPC with CONFIG_MEMORY_HOTPLUG disabled. > > Signed-off-by: Pavel Tatashin > --- >  arch/powerpc/Kconfig | 1 - >  arch/s390/Kconfig    | 1 - >  arch/x86/Kconfig     | 1 - >  mm/Kconfig           | 7 +------ >  4 files changed, 1 insertion(+), 9 deletions(-) > > Looks reasonable to me. Reviewed-by: Khalid Aziz