From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751389AbdKUUDK (ORCPT ); Tue, 21 Nov 2017 15:03:10 -0500 Received: from smtprelay0239.hostedemail.com ([216.40.44.239]:43112 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751067AbdKUUDJ (ORCPT ); Tue, 21 Nov 2017 15:03:09 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3873:4321:5007:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13161:13229:13311:13357:13439:14181:14659:14721:21080:21627:30054:30060:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hands36_5545a4937e13d X-Filterd-Recvd-Size: 2268 Message-ID: <1511294584.6989.34.camel@perches.com> Subject: Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch From: Joe Perches To: Jim Davis , Knut Omang Cc: Luc Van Oostenryck , Masahiro Yamada , Linux Kernel Mailing List , Michal Marek , Linux Kbuild mailing list , Andy Whitcroft Date: Tue, 21 Nov 2017 12:03:04 -0800 In-Reply-To: References: <716fa938a4ab0ad66490b72e2ed750cd6583728f.1510840787.git-series.knut.omang@oracle.com> <20171120200827.726yhebihjhrhted@ltop.local> <1511212212.4822.66.camel@oracle.com> <20171120212251.k4uvdstfhg6qtrag@ltop.local> <1511251834.4822.113.camel@oracle.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-11-21 at 12:48 -0700, Jim Davis wrote: > On Tue, Nov 21, 2017 at 1:10 AM, Knut Omang wrote: > > > Would you like to keep the checkpatch changes in some form, or would you rather > > see everything happening in the wrapper? > > I don't have a strong preference one way or another, but keeping > everything in a wrapper script might be easier if only because you > wouldn't need to get signoffs from whoever maintains checkpatch too. Keeping everything in a wrapper script would also allow any arbitrary checker to be run with minimal changes to the Makefile/build subsystem.