From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbdKVM5G (ORCPT ); Wed, 22 Nov 2017 07:57:06 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38067 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbdKVM5E (ORCPT ); Wed, 22 Nov 2017 07:57:04 -0500 X-Google-Smtp-Source: AGs4zMYP6to/T6It8R7eJmOzTSEAbTn7sM+65PGXLWaRKO4bbgsUthYPRTaA0lKuDmgWsUgKKLwlUQ== Message-ID: <1511355422.12667.14.camel@elementarea.net> Subject: Re: [PATCH v3] checkpatch: allow URL >80 chars From: Andreas Brauchli To: Joe Perches , Andy Whitcroft Cc: linux-kernel@vger.kernel.org Date: Wed, 22 Nov 2017 13:57:02 +0100 In-Reply-To: <1511312743.6989.41.camel@perches.com> References: <1511301024.12439.38.camel@elementarea.net> <1511312743.6989.41.camel@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Die, 2017-11-21 at 17:05 -0800, Joe Perches wrote: > On Tue, 2017-11-21 at 22:50 +0100, Andreas Brauchli wrote: > > Allow URL to exceed the 80 char limit for improved interaction in > > adaption to ongoing but undocumented practice. > > > > $ git grep -E '://\S{77}.*' -- '*.[ch]' > > > > The patch checks that the URL is indeed on its own line in that > > only non-word (\W) and underscore characters are allowed beside the > > URL (e.g. ' /* _https://..._ */') > > Perhaps you are overthinking it. > > If a line contains a URL, and it's > $max_line_length, > then it's probably OK not to warn about it as as overly > long line. Yes, I see. I was going for a different solution: if the URL is already over the allowable length, no other content parts would be allowed on the same line. > > I suggest: > > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 95cda3ecc66b..0e42e5ebe2f0 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2875,6 +2875,7 @@ sub process { > # logging functions like pr_info that end in a string > # lines with a single string > # #defines that are a single string > +# lines with an RFC3986 like URL > # > # There are 3 different line length message types: > # LONG_LINE_COMMENT a comment starts before but extends beyond $max_line_length > @@ -2906,6 +2907,10 @@ sub process { > $line =~ /^\+\s*(?:\w+)?\s*DEFINE_PER_CPU/) { > $msg_type = ""; > > + # URL ($rawline is used if the URL is in a comment) > + } elsif ($rawline =~ /^\+.*\b[a-z][\w\.\+\- > + $msg_type = ""; > + > # Otherwise set the alternate message types > > # a comment starts before $max_line_length Thanks, I'll resend this as v4 Thanks, Andreas