From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751799AbdKVP5X (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 10:57:23 -0500
Received: from mail-pl0-f66.google.com ([209.85.160.66]:45476 "EHLO
        mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751438AbdKVP5V (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 10:57:21 -0500
X-Google-Smtp-Source: AGs4zMbU/EqHzqtjpdnxlP537UFKN+PSV0tEnZkWP+IC0sZrFVhzkzAFCogdhSZFkeBJpHRGEC2VHw==
Message-ID: <1511366238.16595.1.camel@gmail.com>
Subject: Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for
 IPv6 pkts
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Aleksey Makarov <aleksey.makarov@auriga.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
        "Goutham, Sunil" <Sunil.Goutham@cavium.com>,
        Robert Richter <rric@kernel.org>, Florian Westphal <fw@strlen.de>,
        Aleksey Makarov <aleksey.makarov@cavium.com>,
        Sunil Goutham <sgoutham@cavium.com>,
        linux-arm-kernel@lists.infradead.org
Date: Wed, 22 Nov 2017 07:57:18 -0800
In-Reply-To: <20171122123727.23580-1-aleksey.makarov@auriga.com>
References: <20171122123727.23580-1-aleksey.makarov@auriga.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-11-22 at 15:37 +0300, Aleksey Makarov wrote:
> From: Sunil Goutham <sgoutham@cavium.com>
> 
> This fixes a previous patch which missed some changes
> and due to which L3 checksum offload was getting enabled
> for IPv6 pkts. And HW is dropping these pkts as it assumes
> the pkt is IPv4 when IP csum offload is set in the SQ
> descriptor.
> 
> Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads
> for ipv6")
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com>
> ---
>  drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
> b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
> index d4496e9afcdf..184d5bdbe7e0 100644
> --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
> +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
> @@ -1355,10 +1355,11 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic,
> struct snd_queue *sq, int qentry,
>  
>  	/* Offload checksum calculation to HW */
>  	if (skb->ip_summed == CHECKSUM_PARTIAL) {
> -		hdr->csum_l3 = 1; /* Enable IP csum calculation */
>  		hdr->l3_offset = skb_network_offset(skb);
>  		hdr->l4_offset = skb_transport_offset(skb);
>  
> +		/* Enable IP HDR csum calculation for V4 pkts */
> +		hdr->csum_l3 = (ip.v4->version == 4) ? 1 : 0;

Have you tried to set hdr->csum_l3 to 0 regardless of version being 4
or 6 ?

This would remove the need for yet another conditional.

AFAIK, linux does not offload IPv4 header checksums to NIC, it is not
worth the trouble.