From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbdKVRQt (ORCPT ); Wed, 22 Nov 2017 12:16:49 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49992 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbdKVRQs (ORCPT ); Wed, 22 Nov 2017 12:16:48 -0500 Subject: Re: [PATCH v4 1/1] perf/bench/numa: Fixup discontiguous/sparse numa nodes From: Satheesh Rajendran To: "Naveen N. Rao" , acme@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@kernel.org Cc: bala24@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com In-Reply-To: <1511366847.k4y13an79p.naveen@linux.ibm.com> References: <1511336642-15389-1-git-send-email-sathnaga@linux.vnet.ibm.com> <1511366847.k4y13an79p.naveen@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 22 Nov 2017 22:18:13 +0530 Mime-Version: 1.0 X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17112217-0020-0000-0000-00000D0D4661 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008105; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000241; SDB=6.00949632; UDB=6.00479530; IPR=6.00729747; BA=6.00005706; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018131; XFM=3.00000015; UTC=2017-11-22 17:06:42 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112217-0021-0000-0000-00005F048A6F Message-Id: <1511369293.11553.2.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-22_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711220229 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-22 at 21:39 +0530, Naveen N. Rao wrote: > >               sum += nr; > >       } > >       BUG_ON(nr_min > nr_max); > > - > >       BUG_ON(sum > g->p.nr_tasks); > > Looks like that change to remove a blank line did slip in, but that's > a  > small nit. Apart from that, the patch looks good to me. > Acked-by: Naveen N. Rao > Hi Naveen, Thanks, have sent v5 with that addressed :-) Regards, -Satheesh > - Naveen