From: Joe Perches <joe@perches.com>
To: Patryk Kocielnik <patryk.kocielnik@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues
Date: Wed, 22 Nov 2017 09:45:46 -0800 [thread overview]
Message-ID: <1511372746.6989.102.camel@perches.com> (raw)
In-Reply-To: <CAGU7hBg+=QbhsS+eMiAhQTtr_R1B4u9hfyOH5KkGRSYat=fJSg@mail.gmail.com>
On Wed, 2017-11-22 at 18:33 +0100, Patryk Kocielnik wrote:
> Joe,
>
> Thank you for your comments!
>
> I did compile it beforehand and it was clean. Did I miss anything?
You also have to compile it afterhand...
i.e.: with your patch applied
$ make allyesconfig
[]
$ make drivers/staging/sm750fb/
[]
CC drivers/staging/sm750fb/sm750.o
drivers/staging/sm750fb/sm750.c: In function ‘lynxfb_set_fbinfo’:
drivers/staging/sm750fb/sm750.c:807:19: error: assignment of read-only location ‘g_fbmode[index]’
g_fbmode[index] = g_def_fbmode;
^
drivers/staging/sm750fb/sm750.c:809:20: error: assignment of read-only location ‘g_fbmode[index]’
g_fbmode[index] = g_fbmode[0];
^
drivers/staging/sm750fb/sm750.c: In function ‘sm750fb_setup’:
drivers/staging/sm750fb/sm750.c:978:17: error: assignment of read-only location ‘g_fbmode[0]’
g_fbmode[0] = opt;
^
drivers/staging/sm750fb/sm750.c:982:17: error: assignment of read-only location ‘g_fbmode[1]’
g_fbmode[1] = opt;
^
scripts/Makefile.build:310: recipe for target 'drivers/staging/sm750fb/sm750.o' failed
make[1]: *** [drivers/staging/sm750fb/sm750.o] Error 1
Makefile:1674: recipe for target 'drivers/staging/sm750fb/' failed
make: *** [drivers/staging/sm750fb/] Error 2
>
prev parent reply other threads:[~2017-11-22 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 15:42 [PATCH] Staging: sm750fb: sm750: fixed coding style issues Patryk Kocielnik
2017-11-22 16:03 ` Joe Perches
[not found] ` <CAGU7hBg+=QbhsS+eMiAhQTtr_R1B4u9hfyOH5KkGRSYat=fJSg@mail.gmail.com>
2017-11-22 17:35 ` Patryk Kocielnik
2017-11-22 17:45 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511372746.6989.102.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patryk.kocielnik@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox