From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Vineet Gupta" <Vineet.Gupta1@synopsys.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] frv: fix build failure
Date: Thu, 23 Nov 2017 17:17:19 +0000	[thread overview]
Message-ID: <1511457437.32422.6.camel@synopsys.com> (raw)
In-Reply-To: <1511302233-5008-1-git-send-email-sudipm.mukherjee@gmail.com>
Hi Sudip,
On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
> The frv defconfig build is failing with the error:
> lib/mpi/mpih-div.o: In function `mpihelp_divrem':
> mpih-div.c:(.text+0x30c): undefined reference to `abort'
> 
> The function 'abort' was never defined for the frv architecture.
> Create 'abort' as is done in other arch like 'arm' and 'unicore32'.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
I'm seeing the same issue building for ARC from today's Linus' tree.
Maybe it worth implementing abort() as a weak function for every arch/platform
that doesn't have it explicitly defined? Otherwise we'll end-up with
useless code duplication.
-Alexey
next prev parent reply	other threads:[~2017-11-23 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 22:10 [PATCH] frv: fix build failure Sudip Mukherjee
2017-11-23 17:17 ` Alexey Brodkin [this message]
2017-11-23 23:01   ` Sudip Mukherjee
2017-11-24  5:02     ` Alexey Brodkin
2017-11-27 18:25   ` Vineet Gupta
2017-12-03 22:32     ` Sudip Mukherjee
2017-12-06 22:00       ` Vineet Gupta
2017-11-27 18:49 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1511457437.32422.6.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).