From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753399AbdKWRRh (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Nov 2017 12:17:37 -0500
Received: from smtprelay2.synopsys.com ([198.182.60.111]:58492 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753156AbdKWRRe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Nov 2017 12:17:34 -0500
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Vineet Gupta" <Vineet.Gupta1@synopsys.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] frv: fix build failure
Thread-Topic: [PATCH] frv: fix build failure
Thread-Index: AQHTZH7qSkWlbJG3G0W2kS2A996VGw==
Date: Thu, 23 Nov 2017 17:17:19 +0000
Message-ID: <1511457437.32422.6.camel@synopsys.com>
References: <1511302233-5008-1-git-send-email-sudipm.mukherjee@gmail.com>
In-Reply-To: <1511302233-5008-1-git-send-email-sudipm.mukherjee@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.121.8.86]
Content-Type: text/plain; charset="utf-8"
Content-ID: <74728CDC7257E44E94F9E62E0073278F@internal.synopsys.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vANHHgIG029543

Hi Sudip,

On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
> The frv defconfig build is failing with the error:
> lib/mpi/mpih-div.o: In function `mpihelp_divrem':
> mpih-div.c:(.text+0x30c): undefined reference to `abort'
> 
> The function 'abort' was never defined for the frv architecture.
> Create 'abort' as is done in other arch like 'arm' and 'unicore32'.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---

I'm seeing the same issue building for ARC from today's Linus' tree.
Maybe it worth implementing abort() as a weak function for every arch/platform
that doesn't have it explicitly defined? Otherwise we'll end-up with
useless code duplication.

-Alexey