From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753445AbdKWXca (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Nov 2017 18:32:30 -0500
Received: from mail-wm0-f49.google.com ([74.125.82.49]:39120 "EHLO
        mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752423AbdKWXc3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Nov 2017 18:32:29 -0500
X-Google-Smtp-Source: AGs4zMbEu7LqEZNUsRY8JPu5pJ1kKTV6FmHOTEUY5Rzsyqq6H6gFiK48OvaumI09gaTMuFj+zF8elw==
Message-ID: <1511479945.8829.1.camel@gmail.com>
Subject: Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from
 sparse
From: Stefano Manni <stefano.manni@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>,
        Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        lustre-devel@lists.lustre.org
Date: Fri, 24 Nov 2017 00:32:25 +0100
In-Reply-To: <20171123222020.GI12736@eros>
References: <20171122193831.11801-1-stefano.manni@gmail.com>
         <20171123045926.GD12736@eros> <20171123115138.5nku6epnct35mmha@mwanda>
         <20171123222020.GI12736@eros>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-11-24 at 09:20 +1100, Tobin C. Harding wrote:
> On Thu, Nov 23, 2017 at 02:51:38PM +0300, Dan Carpenter wrote:
> > On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote:
> > > On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote:
> > > > Fixed some signedness warnings from sparse on lustre.
> > > > 
> > > > Stefano Manni (4):
> > > >   staging: lustre: fixed signedness of some socklnd params
> > > >   staging: lustre: fixed signedness of llite
> > > >   staging: lustre: fixed signedness of lov
> > > >   staging: lustre: fixed signedness of obdclass
> > > 
> > > You may like to use imperative mood for your git log brief
> > > descriptions
> > > Stefano.  
> > > 
> > > s/fixed/fix/
> > > 
> > 
> > Someone once chewed me a second butt hole for not using the
> > imperative
> > mood so I know some people care intensely about this but I think so
> > long
> > as you can understand the description it's fine.  I will never send
> > a
> > patch for that maintainer's subsystem again, btw, which is probably
> > grateful for and now I can poop twice as fast so we're both
> > winners.
> 
> I try to only make these suggestions to people doing clean up patches
> to
> staging, with the reasoning that if we are learning we might as well
> learn the correct method from the start.

It's ok with your suggestion. Not a hard work to rebase 4 commit and
change the commit message.

Thanks,
Stefano