Re: patch for allowing msdos/vfat nfs exports

Alan Cox
2001-07-24T17:52:13Z

> I've been using it for half a day now and so far it hasn't done
> anything bad, but please be careful if you decide to test it and
> backup your data and after testing, be sure to compare your data
> to your backup.

Rename ?

> + struct inode *inode = dentry->d_inode;
> + unsigned int i_pos = MSDOS_I(inode)->i_location;

i_location is not a constant across renames or other operations, so you may
inadvertantly do I/O to completely the wrong file

The infrastructure looks great, I just don't think your handles are safe