Re: Qlogic/FC firmware

Ricky Beam
2001-08-22T18:46:38Z

On Wed, 22 Aug 2001, Alan Cox wrote:
>Read the source code. The driver never reloads the firmware on a running
>card. So if the sparc needed that it never worked anyway, and I don't follow
>your argument.

If the card wasn't setup by the BIOS (OBP in the Sparc case), then the driver
won't work. And as late as 2.4.8, RELOAD_FIRMWARE was set to '1'. Gee,
look what was changed in 2.4.9:

--- v2.4.8/linux/drivers/scsi/qlogicfc.c Sun Aug 12 13:28:00 2001
+++ linux/drivers/scsi/qlogicfc.c Sun Aug 12 10:51:41 2001
@@ -98,7 +98,7 @@
isp2200's firmware.
*/

-#define RELOAD_FIRMWARE 1
+#define RELOAD_FIRMWARE 0

#define USE_NVRAM_DEFAULTS 1

@@ -440,7 +440,7 @@
#define MBOX_SEND_CHANGE_REQUEST 0x0070
#define MBOX_PORT_LOGOUT 0x0071

-#include "qlogicfc_asm.c"
+//#include "qlogicfc_asm.c"

(I will note, that's not even a valid C construct. '//' is a C++ism.)

>Unlike you, I actually read the source

So, was that before or after you removed the firmware? (And who says I don't
read source code? That's the first place I go to find out who fucked up
what. I'm running 2.4.5 and below. The only thing I have running 2.4.9 is
my laptop, and that was a certified nightmare.)

--Ricky