Re: ReiserFS / 2.4.6 / Data Corruption

Hans Reiser
2001-07-27T21:48:58Z

Alan Cox wrote:
>
> > Let us be a bit more precise here. If you click on the help button when deciding whether to select
> > that option it tells you not to do it. What can you say about a distro that doesn't read the help
> > buttons for the kernel options when configuring the kernel? Shovelware?
>
> The alternative was to disable it. Because at the time we had lots of good
> evidence it didnt work reliably. Evidence backed up by the pile of later
> Chris Mason patches.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

Better to disable it than to cripple it.

By the way, how about considering the use of tests before redhat coders put stuff in the linux
kernel? You know, if VFS changes actually got tested before users encountered things like Viro
breaking ReiserFS in 2.4.5, it would be nice.

At Namesys, like all normal software shops, we actually run a test suite before shipping code
externally. We usually try to require that it be tested by at least one person in addition to the
code author.

It would catch things like your gcc problems. Test suites don't catch everything, but they are
considered the responsible thing to do at most places.

Hans