From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbdKZW3q (ORCPT ); Sun, 26 Nov 2017 17:29:46 -0500 Received: from smtprelay0126.hostedemail.com ([216.40.44.126]:33439 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751816AbdKZW3p (ORCPT ); Sun, 26 Nov 2017 17:29:45 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2110:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3351:3622:3865:3868:3871:3872:3874:4078:4081:4321:5007:7903:10004:10400:10848:11232:11658:11914:12663:12740:12760:12895:13069:13255:13311:13357:13439:14659:21080:21212:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: value57_37c9aa0fdc257 X-Filterd-Recvd-Size: 1589 Message-ID: <1511735382.20482.27.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line From: Joe Perches To: Logan Gunthorpe , Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft Date: Sun, 26 Nov 2017 14:29:42 -0800 In-Reply-To: <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-11-26 at 10:38 -0700, Logan Gunthorpe wrote: > > On 25/11/17 11:01 PM, Joe Perches wrote: > > It doesn't really work. > > That's rather hyperbolic and I don't appreciate the tone. What I wrote is neither hyperbolic nor tonal. I'm rather familiar with checkpatch. High false positive messages are avoided by checkpatch and new tests with high false positive rates are not accepted. This proposal has a very high false positive rate. So, as written. nack. Keep at it though. Maybe something useful will be produced with more effort. cheers, Joe