From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbdK0BMu (ORCPT ); Sun, 26 Nov 2017 20:12:50 -0500 Received: from smtprelay0045.hostedemail.com ([216.40.44.45]:35110 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752172AbdK0BMs (ORCPT ); Sun, 26 Nov 2017 20:12:48 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3308:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6119:7808:7903:10004:10400:10848:11232:11658:11914:12257:12295:12740:12760:12895:13069:13161:13229:13255:13311:13357:13439:14659:14721:21063:21080:21212:21324:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: pain96_184d29ebb8120 X-Filterd-Recvd-Size: 2323 Message-ID: <1511745165.20482.34.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line From: Joe Perches To: Julia Lawall Cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft Date: Sun, 26 Nov 2017 17:12:45 -0800 In-Reply-To: References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-11-26 at 23:44 +0100, Julia Lawall wrote: > My semantic patch and results are below. The semantic patch has some > features that may or may not be desired: > > 1. It goes beyond printk, pr_xxx, dev_xxx, and netdev_xxx, by finding > functions that are sometimes used with a format string ending with a > newline. To reduce false positives, such a function is ignored if it is > sometimes used with a string that ends in a space. This could lead to > false positives where actually one of the calls has a \n that it should > not have. > > 2. Coccinelle puts multipart strings on a single line. So the rule goes > a little further and eliminates the multipartness. Basically "xxx " "yyy" > becomes "xxx yyy" regardless of the length of the result. What about the semi-common string concatenation "foo" #var "bar" ? > 3. Some prints appear not to end with a newline because they end with \n. > where .\n was likely intended. Instead of creating \n.\n, the semantic > patch just moves the .to the left of the . And if there was .\n. it just > drops the final period. That may be a problem if the sentence is "something...\n" There seem to be many false positives in here too. cheers, Joe