From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752322AbdK0Bfb (ORCPT <rfc822;w@1wt.eu>);
        Sun, 26 Nov 2017 20:35:31 -0500
Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:47359 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752214AbdK0Bf3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 26 Nov 2017 20:35:29 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1567:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3871:3874:4321:5007:6691:7903:10004:10400:10848:11232:11658:11914:12296:12679:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:21212:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: knee14_4cc9ea5d9db2e
X-Filterd-Recvd-Size: 1465
Message-ID: <1511746526.20482.38.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
        Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Andy Whitcroft <apw@canonical.com>
Date: Sun, 26 Nov 2017 17:35:26 -0800
In-Reply-To: <alpine.DEB.2.20.1711261912150.2111@hadrien>
References: <20171126054037.9743-1-logang@deltatee.com>
         <alpine.DEB.2.20.1711260648130.2387@hadrien>
         <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com>
         <alpine.DEB.2.20.1711261807590.2111@hadrien>
         <3fc88c02-b9b6-80a3-0c41-63e0806d34aa@deltatee.com>
         <alpine.DEB.2.20.1711261912150.2111@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote:
> I just assume that a printk that has no KERN_ is adding a
> newline, which is my understanding of Joe's comment.

More precisely:

Any printk without an initial KERN_CONT prepends a newline
if the last printk content char emitted that is not part
of a printk timestamp/header was not a newline.