From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751348AbdK0JGt (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 04:06:49 -0500
Received: from smtprelay0159.hostedemail.com ([216.40.44.159]:48625 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751141AbdK0JGs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 04:06:48 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6119:7903:10004:10400:10848:11232:11658:11914:12296:12740:12760:12895:13069:13255:13311:13357:13439:14096:14097:14659:14721:21080:21212:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: thumb93_582ecc9dd3b5a
X-Filterd-Recvd-Size: 2307
Message-ID: <1511773604.32426.24.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Date: Mon, 27 Nov 2017 01:06:44 -0800
In-Reply-To: <alpine.DEB.2.20.1711270951450.3445@hadrien>
References: <20171126054037.9743-1-logang@deltatee.com>
          <alpine.DEB.2.20.1711260648130.2387@hadrien>
          <1511676085.20482.18.camel@perches.com>
          <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com>
          <1511735382.20482.27.camel@perches.com>
          <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com>
          <alpine.DEB.2.20.1711270709390.2369@hadrien>
          <ec39f4f5-cfab-a184-0f27-7f0172e2984f@deltatee.com>
          <alpine.DEB.2.20.1711270732550.2369@hadrien>
          <86f3f594-79f7-c2ce-2cc6-f641bd6f55ae@deltatee.com>
         <1511771322.32426.1.camel@perches.com>
         <alpine.DEB.2.20.1711270951450.3445@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-11-27 at 09:52 +0100, Julia Lawall wrote:
> On Mon, 27 Nov 2017, Joe Perches wrote:
> > On Sun, 2017-11-26 at 23:40 -0700, Logan Gunthorpe wrote:
> > > On 26/11/17 11:34 PM, Julia Lawall wrote:
> > > > It would probably be better not to mention the KERN_CONT possibility at
> > > > all.
> > > 
> > > Oh? I don't disagree... but what are we supposed to do in these cases?
> > > The way v2 of my patch works it just says that there is a missing new
> > > line. But Joe calls that a false positive. So if we can't report that
> > > it's missing a new line and we can't say it looks like it needs a
> > > KERN_CONT, then what can we do? The case is obviously wrong in some way
> > > or another so we probably shouldn't just ignore it.
> 
> I meant why not only suggest pr_cont?

Because checkpatch cannot know if the printk is missing a
KERN_CONT or another different KERN_<LEVEL>.