From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751679AbdK0Jmx (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 04:42:53 -0500
Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:39513 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751350AbdK0Jmv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 04:42:51 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:4384:5007:6691:8660:10004:10400:10848:11026:11232:11657:11658:11914:12043:12295:12296:12740:12760:12895:13069:13148:13230:13255:13311:13357:13439:14659:14721:21080:21212:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: war69_6e57a55f18a26
X-Filterd-Recvd-Size: 2564
Message-ID: <1511775756.32426.33.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Date: Mon, 27 Nov 2017 01:42:36 -0800
In-Reply-To: <alpine.DEB.2.20.1711271028510.3445@hadrien>
References: <20171126054037.9743-1-logang@deltatee.com>
                         <alpine.DEB.2.20.1711260648130.2387@hadrien>
                         <1511676085.20482.18.camel@perches.com>
                         <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com>
                         <1511735382.20482.27.camel@perches.com>
                 <alpine.DEB.2.20.1711262334370.2111@hadrien>
                 <1511745165.20482.34.camel@perches.com>
                 <alpine.DEB.2.20.1711270704420.2369@hadrien>
         <1511774737.32426.29.camel@perches.com>
         <alpine.DEB.2.20.1711271028510.3445@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-11-27 at 10:32 +0100, Julia Lawall wrote:
> On Mon, 27 Nov 2017, Joe Perches wrote:
[]
> > below: the gig_dbg macro and _many_ other append a newline to a format
> 
> Still, it seems that the file must contain a bug elsewhere, because the
> presence of this report means that some other call ended in a newline.  It
> could be reasonable to highlight the least popular.
> 
> thanks,
> julia
> 
> > diff -u -p a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c
> > --- a/drivers/isdn/gigaset/ev-layer.c
> > +++ b/drivers/isdn/gigaset/ev-layer.c
> > @@ -411,7 +411,7 @@ static void add_cid_event(struct cardsta
> >  	unsigned next, tail;
> >  	struct event_t *event;
> > 
> > -	gig_dbg(DEBUG_EVENT, "queueing event %d for cid %d", type, cid);
> > +	gig_dbg(DEBUG_EVENT, "queueing event %d for cid %d\n", type, cid);
> > 
> >  	spin_lock_irqsave(&cs->ev_lock, flags);
> > 
> > etc...

Sure, but more than anything, this shows the difficulty
of automating these changes.

Variability of style is high and highlighting was might
be defective produces a lot of noise.

Perhaps the S/N ratio of your script is somewhat better
than the other proposal.