From: "Bernat, Yehezkel" <yehezkel.bernat@intel.com>
To: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
Cc: "andreas.noever@gmail.com" <andreas.noever@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jamet, Michael" <michael.jamet@intel.com>
Subject: Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts
Date: Mon, 27 Nov 2017 16:21:34 +0000 [thread overview]
Message-ID: <1511799651.2950.4.camel@intel.com> (raw)
In-Reply-To: <20171127114858.20893-2-mika.westerberg@linux.intel.com>
On Mon, 2017-11-27 at 14:48 +0300, Mika Westerberg wrote:
> When ring enters polling mode we are expected to mask the ring
> interrupt
> before the callback is called. However, the current code actually
> unmasks it probably because of a copy-paste mistake.
>
> Mask the interrupt properly from now on.
>
> Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings")
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/thunderbolt/nhi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
> index 419a7a90bce0..f45bcbc63738 100644
> --- a/drivers/thunderbolt/nhi.c
> +++ b/drivers/thunderbolt/nhi.c
> @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring
> *ring)
> return;
>
> if (ring->start_poll) {
> - __ring_interrupt_mask(ring, false);
> + __ring_interrupt_mask(ring, true);
> ring->start_poll(ring->poll_data);
> } else {
> schedule_work(&ring->work);
Acked-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
next prev parent reply other threads:[~2017-11-27 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:48 [PATCH 1/2] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry Mika Westerberg
2017-11-27 11:48 ` [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts Mika Westerberg
2017-11-27 16:21 ` Bernat, Yehezkel [this message]
2017-12-01 9:49 ` mika.westerberg
2017-12-01 9:40 ` [PATCH 1/2] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511799651.2950.4.camel@intel.com \
--to=yehezkel.bernat@intel.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox