From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbdK0QVm (ORCPT ); Mon, 27 Nov 2017 11:21:42 -0500 Received: from mga11.intel.com ([192.55.52.93]:52966 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbdK0QVi (ORCPT ); Mon, 27 Nov 2017 11:21:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,465,1505804400"; d="scan'208";a="7622446" From: "Bernat, Yehezkel" To: "mika.westerberg@linux.intel.com" CC: "andreas.noever@gmail.com" , "linux-kernel@vger.kernel.org" , "Jamet, Michael" Subject: Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts Thread-Topic: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts Thread-Index: AQHTZ3W6AQ/qzh0uf0OouMZO8VQfp6MoaHaA Date: Mon, 27 Nov 2017 16:21:34 +0000 Message-ID: <1511799651.2950.4.camel@intel.com> References: <20171127114858.20893-1-mika.westerberg@linux.intel.com> <20171127114858.20893-2-mika.westerberg@linux.intel.com> In-Reply-To: <20171127114858.20893-2-mika.westerberg@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.18.5.2-0ubuntu3.2 authentication-results: spf=none (sender IP is ) smtp.mailfrom=yehezkel.bernat@intel.com; x-originating-ip: [134.191.232.71] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN4PR11MB0995;6:rgroFcnknC2D0Eb1ykOtXYw/9Dp6v9sAXBpfvHio+cYJeIYks8+Fmyi99cZN2TfCxTWxDRI77tZfFMZktR4VnOvzD7df28gE0q7xrlfTU7mkCLLndU1yJi2SxLNFoUwKKI3zmcgCDevdib3UTTYHwNtmFwzJZUSYyeFb3pkplEe0BKSnPEZsjIisRjR+R/omaCvn5pCsijnH5OQlTDkoU3xHwHtDfG63dLM3dgMyLRrkpln7Qv8KWTAkv4E/BAqJqe2tVvIo68KdT7J4fopIEYpcle5FrSHaCYL37BH5bdHT5wyHEAIsePW4JFnXmXhjTK+5XWCCdvnMo6rfF0OGPOusUfDvhMThqF2Cm+N7tR0=;5:ML+WiY5IxxPs+UPTjsWbmTDuGgjVT3MyYlfwzdjzKHWgMY6x3fzzPCHDKcX2UDofJzKMvRwMaQMfxOL5yOeIVksprANPqLeMsVRik9l7tfVHkmGTqaGusY8B2cFCrNk7xWLls80hYO4dV3Kd5QwiGBayrvEujAXcvXhuE/ALJ/8=;24:OJs9XxspSW/upwwHjAQOWhFpvG0XNS7w40/4EHy617z49kUXzPvgzToJKPHchvYbzYwkuRfGTmIk8EQtLxyOU0RM72e3GYBi9AqB7jPMyiA=;7:ljGcZ9aED3OVxXavrg/qTu0vv+nvyzrWanJgm0FJSW8qf4lA7PyPoILr0B6WqHKA98XyLlwsAXLuqd0iFYwZxe0Kgu+CBTDGLSLDVeJnlP5nlhP7cJHMp/5tJl2+xhxZdhURXzBIQ7mjA3kTLxMs5zhZWhtAFpaM26hmNyxBp1eCGvcfWxTLlyCCvT4KGaHbgNKnu3CTnzTLhoBGMWjIj8WTeS47pBbwk6KAsOCfnz3ow+lqIQX3FmBsG8r5TYXx x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: f6956605-423d-4662-682e-08d535b2ed74 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603258);SRVR:BN4PR11MB0995; x-ms-traffictypediagnostic: BN4PR11MB0995: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231022)(10201501046)(3002001)(6041248)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(201708071742011);SRVR:BN4PR11MB0995;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN4PR11MB0995; x-forefront-prvs: 0504F29D72 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(366004)(377424004)(24454002)(199003)(189002)(8936002)(54906003)(2351001)(81166006)(8676002)(81156014)(2501003)(97736004)(36756003)(86362001)(106356001)(2900100001)(105586002)(99286004)(103116003)(3846002)(6116002)(66066001)(14454004)(102836003)(2906002)(4001150100001)(101416001)(5640700003)(50986999)(76176999)(7736002)(3280700002)(33646002)(6436002)(50226002)(478600001)(4326008)(6506006)(6486002)(68736007)(77096006)(189998001)(6512007)(5660300001)(316002)(3660700001)(6916009)(6246003)(2950100002)(53936002)(39060400002)(229853002)(305945005)(25786009)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN4PR11MB0995;H:BN4PR11MB0996.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f6956605-423d-4662-682e-08d535b2ed74 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2017 16:21:34.3635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR11MB0995 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vARGNsJv012987 On Mon, 2017-11-27 at 14:48 +0300, Mika Westerberg wrote: > When ring enters polling mode we are expected to mask the ring > interrupt > before the callback is called. However, the current code actually > unmasks it probably because of a copy-paste mistake. > > Mask the interrupt properly from now on. > > Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings") > Signed-off-by: Mika Westerberg > --- >  drivers/thunderbolt/nhi.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c > index 419a7a90bce0..f45bcbc63738 100644 > --- a/drivers/thunderbolt/nhi.c > +++ b/drivers/thunderbolt/nhi.c > @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring > *ring) >   return; >   >   if (ring->start_poll) { > - __ring_interrupt_mask(ring, false); > + __ring_interrupt_mask(ring, true); >   ring->start_poll(ring->poll_data); >   } else { >   schedule_work(&ring->work); Acked-by: Yehezkel Bernat