From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbdK0R0N (ORCPT ); Mon, 27 Nov 2017 12:26:13 -0500 Received: from smtprelay0129.hostedemail.com ([216.40.44.129]:46080 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753773AbdK0R0K (ORCPT ); Mon, 27 Nov 2017 12:26:10 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3653:3865:3866:3870:3871:3872:3874:4321:4605:5007:6119:7903:10004:10400:10848:11026:11232:11658:11914:12043:12049:12296:12679:12740:12760:12895:13069:13255:13311:13357:13439:14181:14659:14721:21080:21212:21451:21611:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: jail49_527f0bb4f5e1d X-Filterd-Recvd-Size: 2796 Message-ID: <1511803565.32426.52.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line From: Joe Perches To: Logan Gunthorpe , Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft Date: Mon, 27 Nov 2017 09:26:05 -0800 In-Reply-To: <6d424a99-7c3a-9d15-5651-030f52367749@deltatee.com> References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> <1511745165.20482.34.camel@perches.com> <1511774737.32426.29.camel@perches.com> <6d424a99-7c3a-9d15-5651-030f52367749@deltatee.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-11-27 at 10:07 -0700, Logan Gunthorpe wrote: > > On 27/11/17 02:25 AM, Joe Perches wrote: > > [] > > diff -u -p a/lib/locking-selftest.c b/lib/locking-selftest.c > > --- a/lib/locking-selftest.c > > +++ b/lib/locking-selftest.c > > @@ -1186,7 +1186,7 @@ static void dotest(void (*testcase_fn)(v > > > > static inline void print_testname(const char *testname) > > { > > - printk("%33s:", testname); > > + printk("%33s:\n", testname); > > } > > Coincidentally, the checkpatch script does not hit this false positive. > This because a pr_cont actually follows in a #define. It doesn't feel > right but checkpatch does do the correct thing on this one. > > > diff -u -p a/lib/dynamic_debug.c b/lib/dynamic_debug.c > > --- a/lib/dynamic_debug.c > > +++ b/lib/dynamic_debug.c > > @@ -562,7 +562,8 @@ void __dynamic_pr_debug(struct _ddebug * > > vaf.fmt = fmt; > > vaf.va = &args; > > > > - printk(KERN_DEBUG "%s%pV", dynamic_emit_prefix(descriptor, buf), &vaf); > > + printk(KERN_DEBUG "%s%pV\n", dynamic_emit_prefix(descriptor, buf), > > + &vaf); > > > > va_end(args); > > } > > This is a valid false positive that I also missed. However, it can > actually be very easily ignored by checking if the format string ends in > %pV. There were about 100 cases in my results that match this. No, it can't be done that way. $ git grep '%pV\\n"' | wc -l 56 $ git grep '%pV"' | wc -l 146 AFAIK: all of the above are correct as-is.