From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753936AbdK0R2M (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 12:28:12 -0500
Received: from smtprelay0150.hostedemail.com ([216.40.44.150]:33974 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1753105AbdK0R2K (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 12:28:10 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3870:3872:3874:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12740:12760:12895:13069:13255:13311:13357:13439:14659:21080:21212:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: rest38_64227ac92f311
X-Filterd-Recvd-Size: 2037
Message-ID: <1511803686.32426.54.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line
From: Joe Perches <joe@perches.com>
To: Logan Gunthorpe <logang@deltatee.com>,
        Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Andy Whitcroft <apw@canonical.com>
Date: Mon, 27 Nov 2017 09:28:06 -0800
In-Reply-To: <a0c147a5-a727-0ce8-a0c3-200fe3b17e4a@deltatee.com>
References: <20171126054037.9743-1-logang@deltatee.com>
         <alpine.DEB.2.20.1711260648130.2387@hadrien>
         <1511676085.20482.18.camel@perches.com>
         <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com>
         <1511735382.20482.27.camel@perches.com>
         <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com>
         <alpine.DEB.2.20.1711270709390.2369@hadrien>
         <ec39f4f5-cfab-a184-0f27-7f0172e2984f@deltatee.com>
         <alpine.DEB.2.20.1711270732550.2369@hadrien>
         <86f3f594-79f7-c2ce-2cc6-f641bd6f55ae@deltatee.com>
         <1511771322.32426.1.camel@perches.com>
         <a0c147a5-a727-0ce8-a0c3-200fe3b17e4a@deltatee.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-11-27 at 10:20 -0700, Logan Gunthorpe wrote:
> 
> On 27/11/17 01:28 AM, Joe Perches wrote:
> > checkpatch already reports printks without KERN_<level>
> > 
> > # printk should use KERN_* levels
> > 		if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
> > 			WARN("PRINTK_WITHOUT_KERN_LEVEL",
> > 			     "printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
> > 		}
> > 
> 
> Yes, but that kind of misses the mark in a similar way a new line 
> warning misses the mark. Consider:

It doesn't miss any mark.  It simply informs.
Correctness when fixing are a different world of problems.