From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932351AbdK0Rmy (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 12:42:54 -0500
Received: from smtprelay0168.hostedemail.com ([216.40.44.168]:36024 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1753117AbdK0Rmw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 12:42:52 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3868:3871:3872:3874:4321:5007:7903:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13255:13311:13357:13439:14659:21080:21212:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none
X-HE-Tag: wrist87_52eb7a32fa141
X-Filterd-Recvd-Size: 2011
Message-ID: <1511804568.32426.56.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line
From: Joe Perches <joe@perches.com>
To: Logan Gunthorpe <logang@deltatee.com>,
        Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Andy Whitcroft <apw@canonical.com>
Date: Mon, 27 Nov 2017 09:42:48 -0800
In-Reply-To: <322acd87-7708-cc90-c3d1-caad7bd023e5@deltatee.com>
References: <20171126054037.9743-1-logang@deltatee.com>
         <alpine.DEB.2.20.1711260648130.2387@hadrien>
         <1511676085.20482.18.camel@perches.com>
         <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com>
         <1511735382.20482.27.camel@perches.com>
         <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com>
         <alpine.DEB.2.20.1711270709390.2369@hadrien>
         <ec39f4f5-cfab-a184-0f27-7f0172e2984f@deltatee.com>
         <alpine.DEB.2.20.1711270732550.2369@hadrien>
         <86f3f594-79f7-c2ce-2cc6-f641bd6f55ae@deltatee.com>
         <1511771322.32426.1.camel@perches.com>
         <a0c147a5-a727-0ce8-a0c3-200fe3b17e4a@deltatee.com>
         <1511803686.32426.54.camel@perches.com>
         <322acd87-7708-cc90-c3d1-caad7bd023e5@deltatee.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-11-27 at 10:35 -0700, Logan Gunthorpe wrote:
> 
> On 27/11/17 10:28 AM, Joe Perches wrote:
> > It doesn't miss any mark.  It simply informs.
> > Correctness when fixing are a different world of problems.
> 
> So how come the double standard?

No double stardard.  One correctly informs that a bare
printk is not acceptable.

>  Having a missing new line warning 
> simply informs here too.

No it has a high false positive rate and newbies
act on that by submitting bad patches.'