From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753105AbdK1ADA (ORCPT ); Mon, 27 Nov 2017 19:03:00 -0500 Received: from mga07.intel.com ([134.134.136.100]:57885 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbdK1AC7 (ORCPT ); Mon, 27 Nov 2017 19:02:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,466,1505804400"; d="scan'208";a="181288714" From: "Mehta, Sohil" To: "Kammela, Gayatri" , "andriy.shevchenko@linux.intel.com" , "alex.williamson@redhat.com" , "joro@8bytes.org" CC: "Yu, Fenghua" , "linux-kernel@vger.kernel.org" , "Raj, Ashok" , "Shankar, Ravi V" , "dwmw2@infradead.org" , "iommu@lists.linux-foundation.org" , "jacob.jun.pan@linux.intel.com" Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents Thread-Topic: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents Thread-Index: AQHTY8e47l7JVHFHjEek74psCVwxraMhbaqAgAfUTYCAADU8gA== Date: Tue, 28 Nov 2017 00:02:56 +0000 Message-ID: <1511827411.2717.9.camel@intel.com> References: <1511378746-109275-1-git-send-email-sohil.mehta@intel.com> <1511378746-109275-5-git-send-email-sohil.mehta@intel.com> <1511385559.25007.415.camel@linux.intel.com> <2824B99DC70CE746926327C52CA42F76378EA17D@ORSMSX111.amr.corp.intel.com> In-Reply-To: <2824B99DC70CE746926327C52CA42F76378EA17D@ORSMSX111.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.110.4] Content-Type: text/plain; charset="utf-8" Content-ID: <8692B9150A892A47843296AB57D37366@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAS034Ij023568 On Mon, 2017-11-27 at 20:52 +0000, Kammela, Gayatri wrote: > > > > > From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com] > > Sent: Wednesday, November 22, 2017 1:19 PM > >  > > Moreover, see the patch I have just sent [1] and use same > > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily > > move it > > to seq_file.h for everyone to use in the future. > That makes sense! I see your patch is not merged yet, so really > cannot reuse the same macro. I will have to redefine it. Thanks Andy. That's a good suggestion. Are you planning to move the macro to seq_file.h soon? If so, should we include this marco in our patch after it has been merged? Sohil > > > > > > [1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2 > > > > > > -- > > Andy Shevchenko > > Intel Finland Oy