From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbdK1MR2 (ORCPT ); Tue, 28 Nov 2017 07:17:28 -0500 Received: from mga14.intel.com ([192.55.52.115]:21688 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbdK1MRZ (ORCPT ); Tue, 28 Nov 2017 07:17:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="6805968" Message-ID: <1511871351.25007.460.camel@linux.intel.com> Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents From: Andy Shevchenko To: "Mehta, Sohil" , "Kammela, Gayatri" , "alex.williamson@redhat.com" , "joro@8bytes.org" Cc: "Yu, Fenghua" , "linux-kernel@vger.kernel.org" , "Raj, Ashok" , "Shankar, Ravi V" , "dwmw2@infradead.org" , "iommu@lists.linux-foundation.org" , "jacob.jun.pan@linux.intel.com" Date: Tue, 28 Nov 2017 14:15:51 +0200 In-Reply-To: <1511827411.2717.9.camel@intel.com> References: <1511378746-109275-1-git-send-email-sohil.mehta@intel.com> <1511378746-109275-5-git-send-email-sohil.mehta@intel.com> <1511385559.25007.415.camel@linux.intel.com> <2824B99DC70CE746926327C52CA42F76378EA17D@ORSMSX111.amr.corp.intel.com> <1511827411.2717.9.camel@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-11-28 at 00:02 +0000, Mehta, Sohil wrote: > On Mon, 2017-11-27 at 20:52 +0000, Kammela, Gayatri wrote: > > > > > > > > From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com] > > > Sent: Wednesday, November 22, 2017 1:19 PM > > > > > > Moreover, see the patch I have just sent [1] and use same > > > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily > > > move it > > > to seq_file.h for everyone to use in the future. > > > > That makes sense! I see your patch is not merged yet, so really > > cannot reuse the same macro. I will have to redefine it. > > Thanks Andy. That's a good suggestion. Are you planning to move the > macro to seq_file.h soon? If so, should we include this marco in our > patch after it has been merged? Yes, I sent v2 [1] where it's moved to seq_file.h and asked Bluetooth maintainer to create an immutable branch for other subsystems. So far the response is to roll back to v1 AFAIU. [1]: https://patchwork.ozlabs.org/cover/840899/ -- Andy Shevchenko Intel Finland Oy