From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Kammela, Gayatri" <gayatri.kammela@intel.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
"Raj, Ashok" <ashok.raj@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>
Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents
Date: Tue, 28 Nov 2017 15:55:07 +0200 [thread overview]
Message-ID: <1511877307.25007.467.camel@linux.intel.com> (raw)
In-Reply-To: <2824B99DC70CE746926327C52CA42F76378EA17D@ORSMSX111.amr.corp.intel.com>
On Mon, 2017-11-27 at 20:52 +0000, Kammela, Gayatri wrote:
> > Moreover, see the patch I have just sent [1] and use same
> > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily
> > move it
> > to seq_file.h for everyone to use in the future.
>
> That makes sense! I see your patch is not merged yet, so really cannot
> reuse the same macro. I will have to redefine it.
Since response from BT maintainer he won't take seq_file.h change, just
go ahead and create a same macro (with the same name) inside your
module.
In next cycle I can easily consolidate them in one patch then against
seq_file.h.
> > [1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-11-28 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 19:25 [PATCH v2 0/6] Intel IOMMU debugfs support Sohil Mehta
2017-11-22 18:47 ` Raj, Ashok
2017-11-22 19:25 ` [PATCH v2 1/6] iommu/vt-d: Add debugfs support for Intel IOMMU internals Sohil Mehta
2017-11-22 19:25 ` [PATCH v2 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals Sohil Mehta
2017-11-22 19:25 ` [PATCH v2 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show extended " Sohil Mehta
2017-11-22 19:25 ` [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents Sohil Mehta
2017-11-22 21:19 ` Andy Shevchenko
2017-11-27 20:52 ` Kammela, Gayatri
2017-11-28 0:02 ` Mehta, Sohil
2017-11-28 12:15 ` Andy Shevchenko
2017-11-28 13:55 ` Andy Shevchenko [this message]
2017-11-22 19:25 ` [PATCH v2 5/6] iommu/vt-d: Add debugfs extension to show Pasid table contents Sohil Mehta
2017-11-22 19:25 ` [PATCH v2 6/6] iommu/vt-d: Add debugfs support for Intel IOMMU Interrupt remapping Sohil Mehta
2017-11-22 21:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511877307.25007.467.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gayatri.kammela@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=sohil.mehta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox