From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752701AbdK1NzM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 08:55:12 -0500
Received: from mga05.intel.com ([192.55.52.43]:37789 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751908AbdK1NzL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 08:55:11 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; 
   d="scan'208";a="12907395"
Message-ID: <1511877307.25007.467.camel@linux.intel.com>
Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show
 register contents
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Kammela, Gayatri" <gayatri.kammela@intel.com>,
        "Mehta, Sohil" <sohil.mehta@intel.com>, Joerg Roedel <joro@8bytes.org>,
        Alex Williamson <alex.williamson@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>
Date: Tue, 28 Nov 2017 15:55:07 +0200
In-Reply-To: <2824B99DC70CE746926327C52CA42F76378EA17D@ORSMSX111.amr.corp.intel.com>
References: <1511378746-109275-1-git-send-email-sohil.mehta@intel.com>
         <1511378746-109275-5-git-send-email-sohil.mehta@intel.com>
         <1511385559.25007.415.camel@linux.intel.com>
         <2824B99DC70CE746926327C52CA42F76378EA17D@ORSMSX111.amr.corp.intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.2-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-11-27 at 20:52 +0000, Kammela, Gayatri wrote:

> > Moreover, see the patch I have just sent [1] and use same
> > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily
> > move it
> > to seq_file.h for everyone to use in the future.
> 
> That makes sense! I see your patch is not merged yet, so really cannot
> reuse the same macro. I will have to redefine it.

Since response from BT maintainer he won't take seq_file.h change, just
go ahead and create a same macro (with the same name) inside your
module.

In next cycle I can easily consolidate them in one patch then against
seq_file.h.

> > [1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy