From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932894AbdK2PST (ORCPT ); Wed, 29 Nov 2017 10:18:19 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:39968 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbdK2PSR (ORCPT ); Wed, 29 Nov 2017 10:18:17 -0500 X-Google-Smtp-Source: AGs4zMaBkm6GDbIdIzCDzJRPiT0uo3AKvfADXrqB6rhuHL4sqQQVCMAHHFQBPljYUjc7B4+7iG6vfg== Message-ID: <1511968694.4897.111.camel@gmail.com> Subject: Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record() From: Vladislav Valtchev To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com Date: Wed, 29 Nov 2017 17:18:14 +0200 In-Reply-To: <20171129095309.6e0a445a@gandalf.local.home> References: <20171123163335.19078-1-vladislav.valtchev@gmail.com> <20171123163335.19078-5-vladislav.valtchev@gmail.com> <20171128114822.0f80ed1e@gandalf.local.home> <1511893066.1754.8.camel@gmail.com> <20171129095309.6e0a445a@gandalf.local.home> Organization: VMware Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-29 at 09:53 -0500, Steven Rostedt wrote: > On Tue, 28 Nov 2017 20:17:46 +0200 > Vladislav Valtchev wrote: > > > On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote: > > > > > > Is there a reason that init_instance() isn't called in > > > init_common_record_context()? > > > > > > > Hi Steven, > > > > init_instance() has been put into init_common_record_context() later, > > in patch 8, "Making start,extract,stream,profile separate funcs". > > I have to ask. Why isn't it done in this patch. This patch appears to > be the proper place to put it. > There is no reason, actually. You're absolutely right. It's a leftover from several iterations of fixes (originally 'instance' was not part of ctx). Therefore, I'll move that call to init_instance() inside init_common_record_context(). Vlad