Re: [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO()

Rafael J. Wysocki
2017-12-17T17:37:48Z

On Wednesday, November 29, 2017 9:55:23 PM CET Jean Delvare wrote:
> On Wed, 29 Nov 2017 17:20:57 +0100, Vasyl Gomonovych wrote:
> > Fix ptr_ret.cocci warnings:
> > drivers/pnp/pnpbios/core.c:584:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> >
> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> > ---
> > drivers/pnp/pnpbios/core.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
> > index e681140b85d8..077f334fdbae 100644
> > --- a/drivers/pnp/pnpbios/core.c
> > +++ b/drivers/pnp/pnpbios/core.c
> > @@ -581,10 +581,7 @@ static int __init pnpbios_thread_init(void)
> >
> > init_completion(&unload_sem);
> > task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
> > - if (IS_ERR(task))
> > - return PTR_ERR(task);
> > -
> > - return 0;
> > + return PTR_ERR_OR_ZERO(task);
> > }
> >
> > /* Start the kernel thread later: */
>
> Looks good to me.
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
>

Applied, thanks!