From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934966AbdK2Rv6 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 12:51:58 -0500
Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:45695 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S934933AbdK2Rvm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 12:51:42 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:2828:2901:2919:3138:3139:3140:3141:3142:3352:3622:3865:3870:3871:3872:3873:3874:4321:5007:7576:7903:9040:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12740:12760:12895:13069:13311:13357:13439:14096:14097:14659:14721:21080:21433:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: cork15_82c205bf64c32
X-Filterd-Recvd-Size: 1837
Message-ID: <1511977896.19952.69.camel@perches.com>
Subject: Re: [PATCH] jsm_tty: Fix a possible null pointer dereference in two
 functions
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
        linux-serial@vger.kernel.org,
        "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
        Jiri Slaby <jslaby@suse.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Date: Wed, 29 Nov 2017 09:51:36 -0800
In-Reply-To: <20171129173504.GA20581@kroah.com>
References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net>
         <1511976187.19952.65.camel@perches.com> <20171129173504.GA20581@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-11-29 at 17:35 +0000, Greg Kroah-Hartman wrote:
> On Wed, Nov 29, 2017 at 09:23:07AM -0800, Joe Perches wrote:
> > On Wed, 2017-11-29 at 17:40 +0100, SF Markus Elfring wrote:
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Wed, 29 Nov 2017 17:30:36 +0100
> > > 
> > > Move two debug messages so that a null pointer access can not happen
> > > for the variable "ch" in these functions.
> > 
> > An actual defect fix!
> 
> Nope, not at all, this does not "fix" anything.

Well, I believe it does in unusual cases like a
CONFIG_DYNAMIC_DEBUG when this is enabled by an
odd +p in the dynamic debug control file.

> > Here you could probably cc stable too.
> 
> Nope, not worth it.

<shrug>

It's pretty unlikely, but it is an actual defect.