From: Joe Perches <joe@perches.com>
To: Serhii Popovych <spopovyc@redhat.com>, linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
michael@ellerman.id.au, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: Drop prepare_done from struct kvm_resize_hpt and cleanups
Date: Mon, 04 Dec 2017 07:02:05 -0800 [thread overview]
Message-ID: <1512399725.6321.44.camel@perches.com> (raw)
In-Reply-To: <1512398202-8195-2-git-send-email-spopovyc@redhat.com>
On Mon, 2017-12-04 at 09:36 -0500, Serhii Popovych wrote:
> Change comparison against zero to make checkpatch.pl happy.
Huh? Either I'm confused or you are incorrect here.
checkpatch should or does not warn against comparisons
to zero. There is a test for comparison to NULL.
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
[]
> @@ -1547,16 +1561,12 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> if (!resize || (resize->order != shift))
> goto out;
>
> - ret = -EBUSY;
> - if (!resize->prepare_done)
> - goto out;
> -
> ret = resize->error;
> - if (ret != 0)
> + if (ret)
> goto out;
>
> ret = resize_hpt_rehash(resize);
> - if (ret != 0)
> + if (ret)
> goto out;
>
> resize_hpt_pivot(resize);
next prev parent reply other threads:[~2017-12-04 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 14:36 [PATCH v2 0/2] Fix use after free in HPT resizing code and related minor improvements Serhii Popovych
2017-12-04 14:36 ` [PATCH v2 1/2] KVM: PPC: Book3S HV: Drop prepare_done from struct kvm_resize_hpt and cleanups Serhii Popovych
2017-12-04 15:02 ` Joe Perches [this message]
2017-12-04 14:36 ` [PATCH v2 2/2] KVM: PPC: Book3S HV: Fix use after free in case of multiple resize requests Serhii Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512399725.6321.44.camel@perches.com \
--to=joe@perches.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=spopovyc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox