From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbdLDPCL (ORCPT ); Mon, 4 Dec 2017 10:02:11 -0500 Received: from smtprelay0216.hostedemail.com ([216.40.44.216]:34034 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752768AbdLDPCJ (ORCPT ); Mon, 4 Dec 2017 10:02:09 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2731:2828:3138:3139:3140:3141:3142:3352:3622:3867:3871:3873:4321:5007:6119:7903:10004:10400:10848:11026:11232:11658:11914:12043:12438:12663:12740:12760:12895:13069:13255:13311:13357:13439:14181:14659:14721:21080:21627:30054:30070:30089:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hot15_69db740f32539 X-Filterd-Recvd-Size: 1783 Message-ID: <1512399725.6321.44.camel@perches.com> Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: Drop prepare_done from struct kvm_resize_hpt and cleanups From: Joe Perches To: Serhii Popovych , linux-kernel@vger.kernel.org Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, michael@ellerman.id.au, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, david@gibson.dropbear.id.au Date: Mon, 04 Dec 2017 07:02:05 -0800 In-Reply-To: <1512398202-8195-2-git-send-email-spopovyc@redhat.com> References: <1512398202-8195-1-git-send-email-spopovyc@redhat.com> <1512398202-8195-2-git-send-email-spopovyc@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-12-04 at 09:36 -0500, Serhii Popovych wrote: > Change comparison against zero to make checkpatch.pl happy. Huh? Either I'm confused or you are incorrect here. checkpatch should or does not warn against comparisons to zero. There is a test for comparison to NULL. > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c [] > @@ -1547,16 +1561,12 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm, > if (!resize || (resize->order != shift)) > goto out; > > - ret = -EBUSY; > - if (!resize->prepare_done) > - goto out; > - > ret = resize->error; > - if (ret != 0) > + if (ret) > goto out; > > ret = resize_hpt_rehash(resize); > - if (ret != 0) > + if (ret) > goto out; > > resize_hpt_pivot(resize);