From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbdLDXfp (ORCPT ); Mon, 4 Dec 2017 18:35:45 -0500 Received: from smtprelay0009.hostedemail.com ([216.40.44.9]:36100 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751200AbdLDXfn (ORCPT ); Mon, 4 Dec 2017 18:35:43 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:2894:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3873:3874:4321:4605:4823:5007:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:14721:21080:21212:21433:21627:30051:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: smell05_4e9404a1eb90a X-Filterd-Recvd-Size: 2132 Message-ID: <1512430537.6321.58.camel@perches.com> Subject: Re: [PATCH v2] ima: log message to module appraisal error From: Joe Perches To: "Bruno E. O. Meneguele" , Mimi Zohar , Dmitry Kasatkin Cc: linux-integrity@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 04 Dec 2017 15:35:37 -0800 In-Reply-To: <20171204202347.16261-1-brdeoliv@redhat.com> References: <20171204202347.16261-1-brdeoliv@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-12-04 at 18:23 -0200, Bruno E. O. Meneguele wrote: > Simple but useful message log to the user in case of module appraise is > forced and fails due to the lack of file descriptor, that might be > caused by kmod calls to compressed modules. [] > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c [] > @@ -366,8 +366,12 @@ int ima_read_file(struct file *file, enum kernel_read_file_id read_id) > > if (!file && read_id == READING_MODULE) { > if (!sig_enforce && (ima_appraise & IMA_APPRAISE_MODULES) && > - (ima_appraise & IMA_APPRAISE_ENFORCE)) > + (ima_appraise & IMA_APPRAISE_ENFORCE)) { > + pr_err("impossible to appraise a module without a file \ > + descriptor. sig_enforce kernel parameter might \ > + help\n"); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ You should probably use scripts/checkpatch.pl on your proposed patches before sending them. You've got a lot of tabs and spaces after every line continuation. Please coalesce the format on a single line and avoid this defect. pr_err("impossible to appraise a module without a file descriptor. sig_enforce kernel parameter might help\n"); cheers, Joe