From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751028AbdLGG72 (ORCPT ); Thu, 7 Dec 2017 01:59:28 -0500 Received: from smtprelay0002.hostedemail.com ([216.40.44.2]:37576 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750788AbdLGG70 (ORCPT ); Thu, 7 Dec 2017 01:59:26 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3867:3871:3872:3874:4321:5007:6119:9108:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:21627:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: card71_8c66f28a02c39 X-Filterd-Recvd-Size: 2047 Message-ID: <1512629963.960.34.camel@perches.com> Subject: Re: [PATCH] checkpatch: add check for tag Co-Developed-by From: Joe Perches To: Greg Kroah-Hartman Cc: "Tobin C. Harding" , Andy Whitcroft , Andrew Morton , linux-kernel@vger.kernel.org, Thomas Gleixner , Borislav Petkov , Jonathan Corbet Date: Wed, 06 Dec 2017 22:59:23 -0800 In-Reply-To: <20171207065554.GA19722@kroah.com> References: <1512608376-4234-1-git-send-email-me@tobin.cc> <1512628466.960.30.camel@perches.com> <20171207065554.GA19722@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-12-07 at 07:55 +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 06, 2017 at 10:34:26PM -0800, Joe Perches wrote: > > On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote: > > > Recently signature tag Co-Developed-by was added to the > > > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know > > > about it yet. All prior tags used all lowercase characters except for first > > > character. Checks for this format had to be re-worked to allow for the > > > new tag. > > > > > > Add checkpatch checks for Co-Developed-by tag. > > > > [] > > > +++ b/scripts/checkpatch.pl > > > @@ -468,6 +468,7 @@ our $signature_tags = qr{(?xi: > > > Reviewed-by:| > > > Reported-by:| > > > Suggested-by:| > > > + Co-Developed-by:| > > > > I think the extra hyphenate form is poor at best. > > Codeveloped-by: should be the only form. > > That's not what Documentation/process/5.Posting.rst says, sorry. So what? That's easy to change. > So Tobin's patch is correct. Not to me.