From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752095AbdLGUab (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 15:30:31 -0500
Received: from mga07.intel.com ([134.134.136.100]:57275 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750779AbdLGUaa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 15:30:30 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,374,1508828400"; 
   d="scan'208";a="975980"
From: "Mehta, Sohil" <sohil.mehta@intel.com>
To: "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Kammela, Gayatri" <gayatri.kammela@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v3 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show
 extended context internals
Thread-Topic: [PATCH v3 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show
 extended context internals
Thread-Index: AQHTbkRlXqgiP9doF0GUQwDX3P9EG6M2fs6AgAJfU4A=
Date: Thu, 7 Dec 2017 20:30:28 +0000
Message-ID: <1512678653.120652.23.camel@intel.com>
References: <1512531807-24268-1-git-send-email-sohil.mehta@intel.com>
         <1512531807-24268-4-git-send-email-sohil.mehta@intel.com>
         <5A27A787.2060307@linux.intel.com>
In-Reply-To: <5A27A787.2060307@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.25.110.4]
Content-Type: text/plain; charset="utf-8"
Content-ID: <F396509BD8113841A12BCAE741B3C527@intel.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB7KUaVB005618

On Wed, 2017-12-06 at 16:17 +0800, Lu Baolu wrote:
> Hi,
> 
> On 12/06/2017 11:43 AM, Sohil Mehta wrote:
> > 
> > From: Gayatri Kammela <gayatri.kammela@intel.com>
> > 
> > +
> > +	if (new_ext) {
> > +		seq_printf(m, "Higher Context tbl entries for Bus:
> > %d\n", bus);
> > +		ctx_lo = context[0].lo;
> > +
> > +		if (!(ctx_lo & CONTEXT_PASIDE)) {
> > +			context[1].hi = (u64)virt_to_phys(
> > +					iommu->pasid_state_table);
> > +			context[1].lo = (u64)virt_to_phys(iommu-
> > >pasid_table) |
> > +					intel_iommu_get_pts(iommu)
> > ;
> Why do you change the context entries here?
> 

Thanks for catching this. The context entires were mistakenly getting
changed. We'll remove it.