From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbdLGVSB (ORCPT ); Thu, 7 Dec 2017 16:18:01 -0500 Received: from smtprelay0006.hostedemail.com ([216.40.44.6]:43039 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750973AbdLGVR7 (ORCPT ); Thu, 7 Dec 2017 16:17:59 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2692:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:9025:10004:10400:10848:11232:11658:11914:12043:12663:12740:12760:12895:13069:13153:13228:13311:13357:13439:14096:14097:14181:14659:14721:21080:21611:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: crown85_453e45f0c0a27 X-Filterd-Recvd-Size: 1857 Message-ID: <1512681472.1845.7.camel@perches.com> Subject: Re: [PATCH v2 3/3] checkpatch: warn for use of %px From: Joe Perches To: "Tobin C. Harding" Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Date: Thu, 07 Dec 2017 13:17:52 -0800 In-Reply-To: <20171207210653.GK2191@eros> References: <1512531428-3592-1-git-send-email-me@tobin.cc> <1512531428-3592-4-git-send-email-me@tobin.cc> <20171207210653.GK2191@eros> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-12-08 at 08:06 +1100, Tobin C. Harding wrote: > On Wed, Dec 06, 2017 at 02:37:08PM +1100, Tobin C. Harding wrote: > > Usage of the new %px specifier potentially leaks sensitive > > inforamtion. Printing kernel addresses exposes the kernel layout in > > memory, this is potentially exploitable. We have tools in the kernel to > > help us do the right thing. We can have checkpatch warn developers of > > potential dangers of using %px. > > > > Have checkpatch emit a warning for usage of specifier %px. > > > > Signed-off-by: Tobin C. Harding > > Co-developed-by: Joe Perches > > Co-Developed-by: > > Woops. > > Joe I didn't quite understand what you meant when you said that this > could go in via any tree. I'm still learning the whole kernel tree > management thing. Don't checkpatch patches go in via Andy's tree? > > https://git.kernel.org/pub/scm/linux/kernel/git/apw/checkpatch.git/ No, not in quite awhile. Most checkpatch patches go through Andrew Morton's quilt/mm tree.