From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "nicolas.iooss_linux@m4x.org" <nicolas.iooss_linux@m4x.org>
Cc: "kartilak@cisco.com" <kartilak@cisco.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"satishkh@cisco.com" <satishkh@cisco.com>,
"sebaddel@cisco.com" <sebaddel@cisco.com>
Subject: Re: [PATCH 1/1] scsi: fnic: add a space after %p in printf format
Date: Mon, 11 Dec 2017 23:34:31 +0000 [thread overview]
Message-ID: <1513035270.2747.31.camel@wdc.com> (raw)
In-Reply-To: <CAJfZ7=nnfyCV7PT8eHEu8iwKdbmPQjKzCbwA-t3KwEZqks1K0g@mail.gmail.com>
On Mon, 2017-12-11 at 23:54 +0100, Nicolas Iooss wrote:
> On Mon, Dec 11, 2017 at 11:22 PM, Bart Van Assche
> <Bart.VanAssche@wdc.com> wrote:
> > On Sun, 2017-12-10 at 20:23 +0100, Nicolas Iooss wrote:
> > > - "hdr status = %s tag = 0x%x sc = 0x%p"
> > > + "hdr status = %s tag = 0x%x sc = 0x%p "
> > > "scsi_status = %x residual = %d\n",
> >
> > Since the %p format specifier already inserts a 0x prefix, shouldn't 0x%p be changed
> > into %p?
>
> Does it? On the kernel I use it does not, and the documentation for %p
> does not show a 0x prefix
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/printk-formats.txt?h=v4.15-rc3#n57).
Please ignore my comment.
Bart.
next prev parent reply other threads:[~2017-12-11 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 19:23 [PATCH 1/1] scsi: fnic: add a space after %p in printf format Nicolas Iooss
2017-12-11 22:22 ` Bart Van Assche
2017-12-11 22:54 ` Nicolas Iooss
2017-12-11 23:34 ` Bart Van Assche [this message]
2017-12-12 2:43 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513035270.2747.31.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox