From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbdLLQDV (ORCPT ); Tue, 12 Dec 2017 11:03:21 -0500 Received: from smtprelay0074.hostedemail.com ([216.40.44.74]:57492 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751625AbdLLQDO (ORCPT ); Tue, 12 Dec 2017 11:03:14 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3352:3622:3865:3867:4321:5007:8603:10004:10400:10848:11026:11232:11658:11914:12043:12114:12296:12438:12679:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: point28_562c572ac864a X-Filterd-Recvd-Size: 2214 Message-ID: <1513094591.3036.55.camel@perches.com> Subject: Re: [PATCH 1/8] mm/memblock: memblock_is_map/region_memory can be boolean From: Joe Perches To: Yaowei Bai , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org Date: Tue, 12 Dec 2017 08:03:11 -0800 In-Reply-To: <1513047319-22302-2-git-send-email-baiyaowei@cmss.chinamobile.com> References: <1513047319-22302-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1513047319-22302-2-git-send-email-baiyaowei@cmss.chinamobile.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-12-11 at 21:55 -0500, Yaowei Bai wrote: > This patch makes memblock_is_map/region_memory return bool due to these > two functions only using either true or false as its return value. [] > @@ -1690,13 +1690,13 @@ int __init_memblock memblock_search_pfn_nid(unsigned long pfn, > * RETURNS: > * 0 if false, non-zero if true > */ > -int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size) > +bool __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size) > { > int idx = memblock_search(&memblock.memory, base); > phys_addr_t end = base + memblock_cap_size(base, &size); > > if (idx == -1) > - return 0; > + return false; > return (memblock.memory.regions[idx].base + > memblock.memory.regions[idx].size) >= end; > } I'd be more inclined to use a temporary for memblock.memory.regions[idx] so the function was something like: int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size) { phys_addr_t end; struct memblock_region *region; int idx = memblock_search(&memblock.memory, base); if (idx == -1) return 0; end = base + memblock_cap_size(base, &size); region = &memblock.memory.regions[idx]; return (region->base + region->size) >= end; } Maybe change to bool at your option.