From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdLLRab (ORCPT ); Tue, 12 Dec 2017 12:30:31 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:36588 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdLLRa3 (ORCPT ); Tue, 12 Dec 2017 12:30:29 -0500 Message-ID: <1513099827.3110.25.camel@HansenPartnership.com> Subject: Re: [GIT PULL] SCSI fixes for 4.15-rc3 From: James Bottomley To: "Martin K. Petersen" , Linus Torvalds Cc: Johannes Thumshirn , Andrew Morton , linux-scsi , linux-kernel Date: Tue, 12 Dec 2017 09:30:27 -0800 In-Reply-To: References: <1513095686.3110.9.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-12-12 at 12:22 -0500, Martin K. Petersen wrote: > Linus, > > > > > This is utter shite, and doesn't even compile cleanly. > > > > Sure, it's "just" a warning, and the code works. But no, I'm not > > pulling crap like this. If you save a pointer in an integer > > "hostdata[0]" field, then you damn well do the proper casts or > > helper > > functions or something, you don't just ignore the compiler when it > > very reasonably warns about it. > > > > What the hell is going on? Nobody compiled this stuff at all? Or > > nobody cares about new build warnings? > > Arnd and Johannes fixed this up right away: > > https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/? > h=fixes&id=45349821ab3a8d378b8f37e52c6fe1aa1b870c47 Yes, I have that in the current testing batch, how about I push the combined thing on wednesday. James