From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 4.15-rc3
Date: Tue, 12 Dec 2017 09:35:12 -0800 [thread overview]
Message-ID: <1513100112.3110.28.camel@HansenPartnership.com> (raw)
In-Reply-To: <CA+55aFyzrHj+rMN7Ct7xCEWZT=viXYAC1WZjfgFnM_R0tq1n5A@mail.gmail.com>
On Tue, 2017-12-12 at 09:32 -0800, Linus Torvalds wrote:
> On Tue, Dec 12, 2017 at 9:22 AM, Martin K. Petersen
> <martin.petersen@oracle.com> wrote:
> >
> >
> > Arnd and Johannes fixed this up right away:
>
> The commit you point to _is_ the probnlem. It does:
>
> struct bfad_im_port_s *im_port = shost->hostdata[0];
>
> which is utter bullshit crap.
>
> Notice? It's assigning a pointer (im_port), from an integer value
> ("hostdata[0]" is "unsigned long").
>
> The code is garbage.
he means this one:
https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git/commit/?h=fixes&id=48d83282db077f93b2cf40de120f4d6f29eb293b
Which properly encapsulates the reference in a function which does the correct conversions.
James
next prev parent reply other threads:[~2017-12-12 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 16:21 [GIT PULL] SCSI fixes for 4.15-rc3 James Bottomley
2017-12-12 17:16 ` Linus Torvalds
2017-12-12 17:22 ` Martin K. Petersen
2017-12-12 17:30 ` James Bottomley
2017-12-12 17:32 ` Linus Torvalds
2017-12-12 17:35 ` James Bottomley [this message]
2017-12-12 17:37 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2017-12-15 17:08 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513100112.3110.28.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox