From: "Mehta, Sohil" <sohil.mehta@intel.com>
To: "joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kammela, Gayatri" <gayatri.kammela@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals
Date: Wed, 13 Dec 2017 04:30:43 +0000 [thread overview]
Message-ID: <1513139481.16043.2.camel@intel.com> (raw)
In-Reply-To: <5A30905D.9000303@linux.intel.com>
On Wed, 2017-12-13 at 10:28 +0800, Lu Baolu wrote:
>
> > Would the recommendation be to use pr_warn instead of pr_err or
> > should
> > we entirely skip the message altogether?
> Greg ever educated me about the use of debugfs_ functions in
> this thread.
>
> https://spinics.net/lists/linux-usb/msg159384.html
>
> At least we should avoid the warning/error messages here.
>
Thanks. We'll remove the error messages.
next prev parent reply other threads:[~2017-12-13 4:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 3:43 [PATCH v3 0/6] Intel IOMMU debugfs support Sohil Mehta
2017-12-06 3:43 ` [PATCH v3 1/6] iommu/vt-d: Add debugfs support for Intel IOMMU internals Sohil Mehta
2017-12-06 3:43 ` [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals Sohil Mehta
2017-12-06 8:16 ` Lu Baolu
2017-12-07 20:19 ` Mehta, Sohil
2017-12-13 2:28 ` Lu Baolu
2017-12-13 4:30 ` Mehta, Sohil [this message]
2017-12-06 3:43 ` [PATCH v3 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show extended " Sohil Mehta
2017-12-06 8:17 ` Lu Baolu
2017-12-07 20:30 ` Mehta, Sohil
2017-12-06 8:17 ` Lu Baolu
2017-12-06 3:43 ` [PATCH v3 4/6] iommu/vt-d: Add debugfs extension to show register contents Sohil Mehta
2017-12-06 3:43 ` [PATCH v3 5/6] iommu/vt-d: Add debugfs extension to show Pasid table contents Sohil Mehta
2017-12-06 3:43 ` [PATCH v3 6/6] iommu/vt-d: Add debugfs support for Intel IOMMU Interrupt remapping Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513139481.16043.2.camel@intel.com \
--to=sohil.mehta@intel.com \
--cc=alex.williamson@redhat.com \
--cc=andriy.shevchenko@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gayatri.kammela@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox