From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752217AbdLMEat (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 23:30:49 -0500
Received: from mga09.intel.com ([134.134.136.24]:64468 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751577AbdLMEap (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 23:30:45 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,396,1508828400"; 
   d="scan'208";a="2290985"
From: "Mehta, Sohil" <sohil.mehta@intel.com>
To: "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Kammela, Gayatri" <gayatri.kammela@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show
 context internals
Thread-Topic: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show
 context internals
Thread-Index: AQHTbkRjcaPb2F0o/0Wv8AU5+t1WG6M2focAgAJclwCACEKogIAAIkGA
Date: Wed, 13 Dec 2017 04:30:43 +0000
Message-ID: <1513139481.16043.2.camel@intel.com>
References: <1512531807-24268-1-git-send-email-sohil.mehta@intel.com>
         <1512531807-24268-3-git-send-email-sohil.mehta@intel.com>
         <5A27A74C.9070201@linux.intel.com> <1512678006.120652.17.camel@intel.com>
         <5A30905D.9000303@linux.intel.com>
In-Reply-To: <5A30905D.9000303@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.25.110.4]
Content-Type: text/plain; charset="utf-8"
Content-ID: <3801C21E6576734F8FD1DAA3DCBE4EF8@intel.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vBD4Ursl008433

On Wed, 2017-12-13 at 10:28 +0800, Lu Baolu wrote:
> 
> > Would the recommendation be to use pr_warn instead of pr_err or
> > should
> > we entirely skip the message altogether?
> Greg ever educated me about the use of debugfs_ functions in
> this thread.
> 
> https://spinics.net/lists/linux-usb/msg159384.html
> 
> At least we should avoid the warning/error messages here.
> 

Thanks. We'll remove the error messages.