From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532AbdLMPul (ORCPT ); Wed, 13 Dec 2017 10:50:41 -0500 Received: from smtprelay0161.hostedemail.com ([216.40.44.161]:55681 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753395AbdLMPuk (ORCPT ); Wed, 13 Dec 2017 10:50:40 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 10,1,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:966:968:973:982:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2538:2559:2562:2693:2828:2895:3138:3139:3140:3141:3142:3354:3622:3855:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4385:5007:6117:6119:6755:7809:7903:8957:10004:10400:10848:11232:11658:11914:12043:12219:12740:12760:12895:13069:13255:13311:13357:13439:13523:13524:14096:14097:14181:14345:14659:14721:21080:21324:21433:21451:21627:30036:30054:30067:30070:30074:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cream44_224ff29f8b43e X-Filterd-Recvd-Size: 2857 Message-ID: <1513180234.27409.12.camel@perches.com> Subject: Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header and switch to SPDX From: Joe Perches To: "Andrew F. Davis" , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Wed, 13 Dec 2017 07:50:34 -0800 In-Reply-To: <3ff091f8-1366-ab38-dd7b-2633e6f3dd80@ti.com> References: <20171212224311.24045-1-afd@ti.com> <1513131575.3036.67.camel@perches.com> <3ff091f8-1366-ab38-dd7b-2633e6f3dd80@ti.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-12-13 at 09:44 -0600, Andrew F. Davis wrote: > On 12/12/2017 08:19 PM, Joe Perches wrote: > > On Tue, 2017-12-12 at 16:43 -0600, Andrew F. Davis wrote: > > > The filename is often wrong after moves and adds nothing of value, > > > lets drop it. While already here, switch to SPDX. > > > > [] > > > diff --git a/sound/soc/codecs/tlv320aic32x4-i2c.c b/sound/soc/codecs/tlv320aic32x4-i2c.c > > > > [] > > > @@ -1,21 +1,10 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > /* > > > - * linux/sound/soc/codecs/tlv320aic32x4-i2c.c > > > - * > > > * Copyright 2011 NW Digital Radio > > > * > > > * Author: Jeremy McDermond > > > * > > > * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27. > > > - * > > > - * This program is free software; you can redistribute it and/or modify > > > - * it under the terms of the GNU General Public License as published by > > > - * the Free Software Foundation; either version 2 of the License, or > > > - * (at your option) any later version. > > > - * > > > - * This program is distributed in the hope that it will be useful, > > > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > - * GNU General Public License for more details. > > > > nack. Note the "(at your option) any later version" > > > > If you are going to update to spdx and remove the old license > > verbiage, make sure you are adding the correct spdx tag. > > > > My bad, will fix. > > By the way, do you like these spdx update patch? Or would you rather I > drop this one and wait to let some script do it for the whole subsystem? I would not touch any license text until an automated tool can properly do a pass over the entire kernel source tree. All the bsd variants probably require that the original text be left in place too.